Skip to content

Commit dc5165d

Browse files
authored
chore(integrations) Remove unused parameter from find_channel_id_for_rule (#92356)
Previously I deprecated usage of the project parameter. With that change out safely, the formal parameter can be removed.
1 parent 2ecd070 commit dc5165d

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

src/sentry/integrations/slack/tasks/find_channel_id_for_rule.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
),
3333
)
3434
def find_channel_id_for_rule(
35-
project: Project | None,
3635
actions: Sequence[dict[str, Any]],
3736
uuid: str,
3837
rule_id: int | None = None,
@@ -42,13 +41,11 @@ def find_channel_id_for_rule(
4241
) -> None:
4342
redis_rule_status = RedisRuleStatus(uuid)
4443

45-
if not project and project_id:
46-
try:
47-
project = Project.objects.get_from_cache(id=project_id)
48-
except Project.DoesNotExist:
49-
redis_rule_status.set_value("failed")
50-
return
51-
assert project, "find_channel_id_for_rule requires a project or project_id"
44+
try:
45+
project = Project.objects.get_from_cache(id=project_id)
46+
except Project.DoesNotExist:
47+
redis_rule_status.set_value("failed")
48+
return
5249

5350
organization = project.organization
5451
integration_id: int | None = None

0 commit comments

Comments
 (0)