Skip to content

Commit dd99628

Browse files
Abdkhan14Abdullah Khan
authored andcommitted
feat(new-trace): Span drawer db query styling and buttons in vertical layout. (#69335)
<img width="1277" alt="Screenshot 2024-04-19 at 2 47 44 PM" src="https://github.com/getsentry/sentry/assets/60121741/8330ec00-5e01-4d13-a2ad-5a083f6a29a4"> <img width="1283" alt="Screenshot 2024-04-19 at 2 47 26 PM" src="https://github.com/getsentry/sentry/assets/60121741/d02db505-246c-42c7-9d7a-e485078a1b0b"> --------- Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
1 parent 97be5fd commit dd99628

File tree

2 files changed

+50
-9
lines changed

2 files changed

+50
-9
lines changed

static/app/components/events/interfaces/spans/newTraceDetailsSpanDetails.tsx

Lines changed: 27 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ import {GeneralSpanDetailsValue} from 'sentry/views/performance/traceDetails/new
4141
import {spanDetailsRouteWithQuery} from 'sentry/views/performance/transactionSummary/transactionSpans/spanDetails/utils';
4242
import {transactionSummaryRouteWithQuery} from 'sentry/views/performance/transactionSummary/utils';
4343
import {getPerformanceDuration} from 'sentry/views/performance/utils/getPerformanceDuration';
44-
import {SpanDescription} from 'sentry/views/starfish/components/spanDescription';
44+
import {Frame, SpanDescription} from 'sentry/views/starfish/components/spanDescription';
45+
import {FrameContainer} from 'sentry/views/starfish/components/stackTraceMiniFrame';
4546
import {ModuleName} from 'sentry/views/starfish/types';
4647
import {resolveSpanModule} from 'sentry/views/starfish/utils/resolveSpanModule';
4748

@@ -455,11 +456,13 @@ function NewTraceDetailsSpanDetail(props: SpanDetailProps) {
455456
extra={renderSpanDetailActions()}
456457
>
457458
{resolvedModule === ModuleName.DB ? (
458-
<SpanDescription
459-
groupId={span.sentry_tags?.group ?? ''}
460-
op={span.op ?? ''}
461-
preliminaryDescription={span.description}
462-
/>
459+
<SpanDescriptionWrapper>
460+
<SpanDescription
461+
groupId={span.sentry_tags?.group ?? ''}
462+
op={span.op ?? ''}
463+
preliminaryDescription={span.description}
464+
/>
465+
</SpanDescriptionWrapper>
463466
) : (
464467
span.description
465468
)}
@@ -735,13 +738,13 @@ const Flex = styled('div')`
735738
display: flex;
736739
align-items: center;
737740
`;
738-
const ButtonGroup = styled('div')`
741+
export const ButtonGroup = styled('div')`
739742
display: flex;
740743
flex-direction: column;
741744
gap: ${space(0.5)};
742745
`;
743746

744-
const ValueRow = styled('div')`
747+
export const ValueRow = styled('div')`
745748
display: grid;
746749
grid-template-columns: auto min-content;
747750
gap: ${space(1)};
@@ -756,12 +759,27 @@ const StyledPre = styled('pre')`
756759
background-color: transparent !important;
757760
`;
758761

759-
const ButtonContainer = styled('div')`
762+
export const ButtonContainer = styled('div')`
760763
padding: 8px 10px;
761764
`;
762765

763766
const StyledQuestionTooltip = styled(QuestionTooltip)`
764767
margin-left: ${space(0.5)};
765768
`;
766769

770+
const SpanDescriptionWrapper = styled('div')`
771+
${Frame} {
772+
border: none;
773+
}
774+
775+
${FrameContainer} {
776+
padding: ${space(2)} 0 0 0;
777+
margin-top: ${space(2)};
778+
}
779+
780+
pre {
781+
padding: 0 !important;
782+
}
783+
`;
784+
767785
export default NewTraceDetailsSpanDetail;

static/app/views/performance/newTraceDetails/traceDrawer/traceDrawer.tsx

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ import pick from 'lodash/pick';
55

66
import type {Tag} from 'sentry/actionCreators/events';
77
import {Button} from 'sentry/components/button';
8+
import {
9+
ButtonContainer,
10+
ButtonGroup,
11+
ValueRow,
12+
} from 'sentry/components/events/interfaces/spans/newTraceDetailsSpanDetails';
813
import {IconChevron, IconPanel, IconPin} from 'sentry/icons';
914
import {t} from 'sentry/locale';
1015
import {space} from 'sentry/styles/space';
@@ -754,6 +759,24 @@ const Content = styled('div')<{layout: 'drawer bottom' | 'drawer left' | 'drawer
754759
tr {
755760
display: grid;
756761
}
762+
763+
${ValueRow}{
764+
grid-template-columns: none;
765+
grid-template-rows: min-content min-content;
766+
gap: 0;
767+
768+
pre {
769+
padding-bottom: 0 !important;
770+
}
771+
772+
${ButtonContainer} {
773+
padding-top: 0;
774+
775+
${ButtonGroup} {
776+
flex-direction: row;
777+
}
778+
}
779+
}
757780
`}
758781
`;
759782

0 commit comments

Comments
 (0)