Skip to content

Commit dfd9dd9

Browse files
committed
fix migration test
1 parent 52213bf commit dfd9dd9

File tree

1 file changed

+25
-16
lines changed

1 file changed

+25
-16
lines changed
Lines changed: 25 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
from sentry.hybridcloud.models.outbox import outbox_context
2-
from sentry.models.dashboard_widget import DashboardWidgetTypes, DatasetSourcesTypes
2+
from sentry.models.dashboard_widget import (
3+
DashboardWidgetDisplayTypes,
4+
DashboardWidgetTypes,
5+
DatasetSourcesTypes,
6+
)
7+
from sentry.models.organization import Organization
38
from sentry.testutils.cases import SnubaTestCase, TestMigrations
49

510

@@ -8,7 +13,6 @@ class SplitDiscoverDatasetDashboardsSelfHostedTest(TestMigrations, SnubaTestCase
813
migrate_to = "0905_split_discover_dataset_dashboards_self_hosted"
914

1015
def setup_before_migration(self, apps):
11-
Organization = apps.get_model("sentry", "Organization")
1216
User = apps.get_model("sentry", "User")
1317
Dashboard = apps.get_model("sentry", "Dashboard")
1418
DashboardWidget = apps.get_model("sentry", "DashboardWidget")
@@ -20,59 +24,64 @@ def setup_before_migration(self, apps):
2024

2125
self.dashboard = Dashboard.objects.create(
2226
title="test",
23-
organization=self.organization,
24-
created_by=self.user,
27+
organization_id=self.organization.id,
28+
created_by_id=self.user.id,
2529
)
2630

2731
self.discover_widget = DashboardWidget.objects.create(
28-
dashboard=self.dashboard,
32+
dashboard_id=self.dashboard.id,
2933
title="test discover widget",
3034
widget_type=DashboardWidgetTypes.DISCOVER,
31-
dataset_source=DatasetSourcesTypes.UNKNOWN,
35+
dataset_source=DatasetSourcesTypes.UNKNOWN.value,
36+
display_type=DashboardWidgetDisplayTypes.LINE_CHART,
37+
interval="1d",
38+
order=0,
3239
)
40+
3341
self.discover_widget_query = DashboardWidgetQuery.objects.create(
34-
widget=self.discover_widget,
42+
widget_id=self.discover_widget.id,
3543
name="test discover widget query",
3644
fields=["count()"],
3745
aggregates=["count()"],
3846
columns=[],
3947
conditions=[],
40-
limit=10,
4148
orderby=["-count()"],
4249
order=0,
4350
)
4451

4552
self.migrated_discover_widget = DashboardWidget.objects.create(
46-
dashboard=self.dashboard,
53+
dashboard_id=self.dashboard.id,
4754
title="test migrated discover widget",
4855
widget_type=DashboardWidgetTypes.DISCOVER,
49-
dataset_source=DatasetSourcesTypes.UNKNOWN,
56+
dataset_source=DatasetSourcesTypes.UNKNOWN.value,
5057
discover_widget_split=DashboardWidgetTypes.TRANSACTION_LIKE,
58+
display_type=DashboardWidgetDisplayTypes.LINE_CHART,
59+
interval="1d",
60+
order=1,
5161
)
5262

5363
self.migrated_discover_widget_query = DashboardWidgetQuery.objects.create(
54-
widget=self.migrated_discover_widget,
64+
widget_id=self.migrated_discover_widget.id,
5565
name="test migrated discover widget query",
5666
fields=["count()"],
5767
aggregates=["count()"],
5868
columns=[],
5969
conditions=[],
60-
limit=10,
6170
orderby=["-count()"],
62-
order=0,
71+
order=1,
6372
)
6473

6574
def test(self):
6675
self.discover_widget.refresh_from_db()
6776
self.migrated_discover_widget.refresh_from_db()
6877

6978
assert self.discover_widget.discover_widget_split == DashboardWidgetTypes.ERROR_EVENTS
70-
assert self.discover_widget.widget_type == DashboardWidgetTypes.ERROR_EVENTS
71-
assert self.discover_widget.dataset_source == DatasetSourcesTypes.FORCED
79+
assert self.discover_widget.widget_type == DashboardWidgetTypes.DISCOVER
80+
assert self.discover_widget.dataset_source == DatasetSourcesTypes.FORCED.value
7281

7382
assert (
7483
self.migrated_discover_widget.discover_widget_split
7584
== DashboardWidgetTypes.TRANSACTION_LIKE
7685
)
7786
assert self.migrated_discover_widget.widget_type == DashboardWidgetTypes.DISCOVER
78-
assert self.migrated_discover_widget.dataset_source == DatasetSourcesTypes.UNKNOWN
87+
assert self.migrated_discover_widget.dataset_source == DatasetSourcesTypes.UNKNOWN.value

0 commit comments

Comments
 (0)