Merge branch 'master' into snigdha/fix-ios-notif

Author: snigdhas

.github/CODEOWNERS

@@ -368,8 +368,6 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py     @ge
 /src/sentry/toolbar/                         @getsentry/replay-frontend @getsentry/replay-backend
 /tests/sentry/toolbar/                       @getsentry/replay-frontend @getsentry/replay-backend
 /static/app/components/devtoolbar/           @getsentry/replay-frontend
-/src/sentry/middleware/devtoolbar.py         @getsentry/replay-backend
-/tests/sentry/middleware/test_devtoolbar.py  @getsentry/replay-backend
 ## End of DevToolbar
 
 ## Codecov Merge UX

.github/workflows/acceptance.yml

@@ -84,7 +84,7 @@ jobs:
         uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
         with:
           path: ${{ steps.config.outputs.webpack-path }}
-          key: ${{ runner.os }}-v2-webpack-cache-${{ hashFiles('webpack.config.ts') }}
+          key: ${{ runner.os }}-v2-webpack-cache-${{ hashFiles('rspack.config.ts', 'yarn.lock', 'package.json') }}
 
       - name: node_modules cache
         uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0

CHANGES

@@ -1,3 +1,35 @@
+25.5.0
+------
+
+### Various fixes & improvements
+
+- chore(perf-issues): Add a flag and check it to allow customer to disable detectors (#91734) by @leeandher
+- feat(trace-tabs-ui): Adding ops to search on click and hiding trace level ops breakdown (#91684) by @Abdkhan14
+- build(ui): Add rspack as webpack alternative (#77077) by @scttcper
+- fix(taskworker) Fix async notification parameter serialization (#91720) by @markstory
+- fix(profiles): Set the proper span entity to insert data to in tests (#91736) by @phacops
+- fix(insights): line of code not working with db module on eap (#91654) by @DominikB2014
+- ref(reserved budgets): Update types + constants (#91606) by @isabellaenriquez
+- feat(taskworker) Check 2% of tasks for pickle (#91624) by @markstory
+- chore(github): Only support pagination for getting labels (#91570) by @armenzg
+- Skip test_queries_profile_candidates_from_spans (#91724) by @armenzg
+- fix(issue-details): Avoid persisting stacktrace folding behaviour (#91719) by @leeandher
+- feat(dashboards): Newly added widgets should scroll into view (#91721) by @narsaynorath
+- ref(crons): Use dateAdded over dateCreated (#91667) by @evanpurkhiser
+- fix(utils): return 0% for null and undefined values in formatpercentage (#91710) by @shellmayr
+- ref: fix nullability of requires_org_level_access (#91694) by @asottile-sentry
+- feat(explore): Flatten visualize yaxes into multiple (#91664) by @Zylphrex
+- fix(widget-library): Hide filters at top of panel if not small screen (#91716) by @narsaynorath
+- feat(attachments): Include all attachment with screenshot in name (#91602) by @armenzg
+- fix(insights): show - instead of null when metric value is null (#91656) by @DominikB2014
+- feat(ourlogs): Add a "new" badge for logs in the sidebar (#91674) by @colin-sentry
+- fix(nextjs-insights): remove project icon from rage/dead click widget (#91711) by @shellmayr
+- fix(nextjs-insights): show 0% for failure_rate()==0 instead of <0% (#91709) by @shellmayr
+- feat(nextjs-insights): add avg & p95 duration to navigations table (#91708) by @shellmayr
+- fix(sandbox): for debugging add telex org to exclude from redirect (#91704) by @constantinius
+
+_Plus 1819 more_
+
 25.4.0
 ------
 

build-utils/last-built-plugin.ts

@@ -1,6 +1,6 @@
 import fs from 'node:fs';
 import path from 'node:path';
-import type webpack from 'webpack';
+import type {Compiler} from 'webpack';
 
 type Options = {
   basePath: string;
@@ -15,7 +15,7 @@ class LastBuiltPlugin {
     this.isWatchMode = false;
   }
 
-  apply(compiler: webpack.Compiler) {
+  apply(compiler: Compiler) {
     compiler.hooks.watchRun.tapAsync('LastBuiltPlugin', (_, callback) => {
       this.isWatchMode = true;
       callback();

eslint.config.mjs

@@ -43,6 +43,7 @@ export const typeAwareLintRules = {
   rules: {
     '@typescript-eslint/await-thenable': 'error',
     '@typescript-eslint/no-array-delete': 'error',
+    '@typescript-eslint/no-base-to-string': 'error',
     '@typescript-eslint/no-for-in-array': 'error',
     '@typescript-eslint/no-unnecessary-type-assertion': 'error',
     '@typescript-eslint/prefer-optional-chain': 'error',

migrations_lockfile.txt

@@ -13,20 +13,20 @@ hybridcloud: 0021_django_arrayfield_scope_list
 
 insights: 0001_add_starred_transactions_model
 
-monitors: 0002_fix_drift_default_to_db_default
+monitors: 0005_record_date_in_progress_state
 
 nodestore: 0002_nodestore_no_dictfield
 
 remote_subscriptions: 0003_drop_remote_subscription
 
 replays: 0005_drop_replay_index
 
-sentry: 0895_relocation_provenance_smallint
+sentry: 0904_onboarding_task_project_id_idx
 
 social_auth: 0002_default_auto_field
 
 tempest: 0002_make_message_type_nullable
 
-uptime: 0041_uptime_backfill_detector_grouphash
+uptime: 0042_extra_uptime_indexes
 
-workflow_engine: 0060_rename_azure_devops_action_to_vsts
+workflow_engine: 0063_drop_rollout_workflowfirehistory_columns

package.json

@@ -51,7 +51,10 @@
     "@react-stately/tabs": "^3.6.9",
     "@react-stately/tree": "^3.8.4",
     "@react-types/shared": "^3.24.1",
-    "@rsdoctor/webpack-plugin": "1.0.1",
+    "@rsdoctor/webpack-plugin": "1.1.2",
+    "@rspack/cli": "1.3.10",
+    "@rspack/core": "1.3.10",
+    "@rspack/plugin-react-refresh": "1.4.3",
     "@sentry-internal/global-search": "^1.0.0",
     "@sentry-internal/rrweb": "2.34.0",
     "@sentry-internal/rrweb-player": "2.34.0",
@@ -61,7 +64,7 @@
     "@sentry/react": "9.16.1",
     "@sentry/release-parser": "^1.3.1",
     "@sentry/status-page-list": "^0.6.0",
-    "@sentry/webpack-plugin": "^3.1.1",
+    "@sentry/webpack-plugin": "^3.4.0",
     "@spotlightjs/spotlight": "^2.0.0-alpha.1",
     "@tanstack/query-async-storage-persister": "^5.72.1",
     "@tanstack/react-query": "^5.72.1",
@@ -163,6 +166,7 @@
     "sprintf-js": "1.0.3",
     "style-loader": "4.0.0",
     "terser-webpack-plugin": "5.3.14",
+    "ts-checker-rspack-plugin": "1.1.3",
     "ts-node": "^10.9.2",
     "tslib": "^2.8.1",
     "typescript": "^5.8.3",
@@ -178,10 +182,12 @@
     "@eslint/compat": "^1.2.7",
     "@eslint/eslintrc": "^3.3.0",
     "@eslint/js": "^9.22.0",
+    "@mdx-js/loader": "^3.1.0",
     "@pmmmwh/react-refresh-webpack-plugin": "0.5.16",
     "@sentry/jest-environment": "6.0.0",
     "@sentry/profiling-node": "9.16.1",
     "@styled/typescript-styled-plugin": "^1.0.1",
+    "@swc/plugin-emotion": "9.0.4",
     "@tanstack/eslint-plugin-query": "^5.66.1",
     "@testing-library/dom": "10.4.0",
     "@testing-library/jest-dom": "6.6.3",
@@ -245,19 +251,28 @@
     "fix:eslint": "eslint --fix",
     "fix:prettier": "prettier \"**/*.md\" \"**/*.yaml\" \"**/*.[jt]s(x)?\" --write --log-level=error",
     "dev": "(yarn check --verify-tree || yarn install --check-files) && sentry devserver",
-    "dev-ui": "SENTRY_UI_DEV_ONLY=1 SENTRY_WEBPACK_PROXY_PORT=7999 SENTRY_UI_HOT_RELOAD=1 webpack serve",
+    "dev-ui": "yarn dev-ui-rspack",
+    "dev-ui-webpack": "SENTRY_UI_DEV_ONLY=1 SENTRY_WEBPACK_PROXY_PORT=7999 SENTRY_UI_HOT_RELOAD=1 webpack serve",
+    "dev-ui-rspack": "SENTRY_UI_DEV_ONLY=1 SENTRY_WEBPACK_PROXY_PORT=7999 SENTRY_UI_HOT_RELOAD=1 rspack serve",
     "dev-ui-admin": "SENTRY_ADMIN_UI_DEV=1 yarn dev-ui",
     "dev-ui-storybook": "STORYBOOK_TYPES=1 yarn dev-ui",
+    "dev-ui-storybook-rspack": "STORYBOOK_TYPES=1 yarn dev-ui-rspack",
     "dev-acceptance": "NO_DEV_SERVER=1 NODE_ENV=development webpack --watch",
+    "dev-acceptance-rspack": "NO_DEV_SERVER=1 NODE_ENV=development rspack --watch",
     "webpack-profile": "NO_TS_FORK=1 webpack --profile --json > stats.json",
+    "webpack-profile-rspack": "NO_TS_FORK=1 rspack build --json > stats.json",
     "install-api-docs": "yarn install --cwd ./api-docs",
     "build-deprecated-docs": "yarn install-api-docs && ts-node api-docs/index.ts api-docs/openapi.json tests/apidocs/openapi-deprecated.json",
     "diff-docs": "yarn install-api-docs && ts-node api-docs/openapi-diff.ts",
     "deref-api-docs": "ts-node api-docs/index.ts tests/apidocs/openapi-spectacular.json tests/apidocs/openapi-derefed.json",
     "build-chartcuterie-config": "node --experimental-strip-types config/build-chartcuterie.ts",
-    "build-acceptance": "CODECOV_ENABLE_BA=false IS_ACCEPTANCE_TEST=1 NODE_ENV=production webpack",
+    "build-acceptance-rspack": "CODECOV_ENABLE_BA=false IS_ACCEPTANCE_TEST=1 NODE_ENV=production rspack",
+    "build-acceptance-webpack": "CODECOV_ENABLE_BA=false IS_ACCEPTANCE_TEST=1 NODE_ENV=production webpack",
+    "build-acceptance": "yarn build-acceptance-rspack",
     "build-production": "NODE_ENV=production webpack --mode production",
+    "build-production-rspack": "NODE_ENV=production rspack --mode production",
     "build": "NODE_OPTIONS=--max-old-space-size=4096 webpack",
+    "build-rspack": "NODE_OPTIONS=--max-old-space-size=4096 rspack",
     "build-js-loader": "ts-node scripts/build-js-loader.ts",
     "build-js-po": "node --experimental-strip-types build-utils/ts-extract-gettext.ts",
     "validate-api-examples": "yarn --cwd api-docs openapi-examples-validator ../tests/apidocs/openapi-derefed.json --no-additional-properties",

pyproject.toml

@@ -290,10 +290,10 @@ module = [
     "sentry.issues.endpoints.related_issues",
     "sentry.issues.endpoints.shared_group_details",
     "sentry.issues.endpoints.team_groups_old",
-    "sentry.issues.escalating",
-    "sentry.issues.escalating_group_forecast",
-    "sentry.issues.escalating_issues_alg",
-    "sentry.issues.forecasts",
+    "sentry.issues.escalating.escalating",
+    "sentry.issues.escalating.escalating_group_forecast",
+    "sentry.issues.escalating.escalating_issues_alg",
+    "sentry.issues.escalating.forecasts",
     "sentry.issues.ignored",
     "sentry.issues.ingest",
     "sentry.issues.issue_occurrence",
@@ -480,16 +480,16 @@ module = [
     "tests.sentry.issues.endpoints.test_shared_group_details",
     "tests.sentry.issues.endpoints.test_source_map_debug",
     "tests.sentry.issues.endpoints.test_team_groups_old",
+    "tests.sentry.issues.escalating.test_escalating",
+    "tests.sentry.issues.escalating.test_escalating_issues_alg",
+    "tests.sentry.issues.escalating.test_issue_velocity",
     "tests.sentry.issues.ownership.*",
     "tests.sentry.issues.test_attributes",
-    "tests.sentry.issues.test_escalating",
-    "tests.sentry.issues.test_escalating_issues_alg",
     "tests.sentry.issues.test_group_attributes_dataset",
     "tests.sentry.issues.test_grouptype",
     "tests.sentry.issues.test_ignored",
     "tests.sentry.issues.test_ingest",
     "tests.sentry.issues.test_issue_occurrence",
-    "tests.sentry.issues.test_issue_velocity",
     "tests.sentry.issues.test_json_schemas",
     "tests.sentry.issues.test_merge",
     "tests.sentry.issues.test_occurrence_consumer",

requirements-base.txt

@@ -50,7 +50,7 @@ psutil>=5.9.2
 psycopg2-binary>=2.9.10
 PyJWT>=2.4.0
 pydantic>=1.10.20,<2
-python-dateutil>=2.9.0
+python-dateutil>=2.9.0.post0
 pymemcache
 python-u2flib-server>=5.0.0
 fido2>=0.9.2
@@ -71,7 +71,7 @@ sentry-ophio>=1.1.3
 sentry-protos==0.2.0
 sentry-redis-tools>=0.5.0
 sentry-relay>=0.9.9
-sentry-sdk[http2]>=2.25.1
+sentry-sdk[http2]>=2.29.1
 slack-sdk>=3.27.2
 snuba-sdk>=3.0.43
 simplejson>=3.17.6

requirements-dev-frozen.txt

@@ -130,7 +130,7 @@ platformdirs==4.2.0
 pluggy==1.5.0
 pre-commit==4.2.0
 progressbar2==3.41.0
-prompt-toolkit==3.0.41
+prompt-toolkit==3.0.51
 proto-plus==1.25.0
 protobuf==5.27.3
 psutil==5.9.7
@@ -155,7 +155,7 @@ pytest-rerunfailures==15.0
 pytest-sentry==0.3.0
 pytest-workaround-12888==1.0.0
 pytest-xdist==3.0.2
-python-dateutil==2.9.0
+python-dateutil==2.9.0.post0
 python-rapidjson==1.8
 python-u2flib-server==5.0.0
 python-utils==3.3.3
@@ -192,18 +192,18 @@ sentry-ophio==1.1.3
 sentry-protos==0.2.0
 sentry-redis-tools==0.5.0
 sentry-relay==0.9.9
-sentry-sdk==2.27.0
+sentry-sdk==2.29.1
 sentry-usage-accountant==0.0.10
 simplejson==3.17.6
-six==1.16.0
+six==1.17.0
 slack-sdk==3.27.2
 sniffio==1.3.1
 snuba-sdk==3.0.43
 sortedcontainers==2.4.0
 soupsieve==2.3.2.post1
 sqlparse==0.5.0
 statsd==3.3.0
-stripe==5.5.0
+stripe==6.7.0
 structlog==22.1.0
 supervisor==4.2.5
 symbolic==12.14.1
@@ -234,15 +234,15 @@ types-setuptools==69.0.0.0
 types-simplejson==3.17.7.2
 types-unidiff==0.7.0.20240505
 typing-extensions==4.12.0
-tzdata==2023.3
+tzdata==2025.2
 ua-parser==0.10.0
 unidiff==0.7.4
 uritemplate==4.1.1
 urllib3==2.2.2
 vine==5.1.0
 virtualenv==20.26.6
 vroomrs==0.1.4
-wcwidth==0.2.10
+wcwidth==0.2.13
 werkzeug==3.0.6
 wheel==0.38.4
 wrapt==1.17.0

requirements-frozen.txt

@@ -89,7 +89,7 @@ petname==2.6
 phonenumberslite==8.12.55
 pillow==11.0.0
 progressbar2==3.41.0
-prompt-toolkit==3.0.41
+prompt-toolkit==3.0.51
 proto-plus==1.25.0
 protobuf==5.27.3
 psutil==5.9.7
@@ -101,7 +101,7 @@ pycparser==2.21
 pydantic==1.10.20
 pyjwt==2.4.0
 pymemcache==4.0.0
-python-dateutil==2.9.0
+python-dateutil==2.9.0.post0
 python-rapidjson==1.8
 python-u2flib-server==5.0.0
 python-utils==3.3.3
@@ -130,32 +130,32 @@ sentry-ophio==1.1.3
 sentry-protos==0.2.0
 sentry-redis-tools==0.5.0
 sentry-relay==0.9.9
-sentry-sdk==2.27.0
+sentry-sdk==2.29.1
 sentry-usage-accountant==0.0.10
 simplejson==3.17.6
-six==1.16.0
+six==1.17.0
 slack-sdk==3.27.2
 sniffio==1.3.1
 snuba-sdk==3.0.43
 soupsieve==2.3.2.post1
 sqlparse==0.5.0
 statsd==3.3.0
-stripe==5.5.0
+stripe==6.7.0
 structlog==22.1.0
 symbolic==12.14.1
 tiktoken==0.8.0
 tldextract==5.1.2
 toronado==0.1.0
 tqdm==4.66.4
 typing-extensions==4.12.0
-tzdata==2023.3
+tzdata==2025.2
 ua-parser==0.10.0
 unidiff==0.7.4
 uritemplate==4.1.1
 urllib3==2.2.2
 vine==5.1.0
 vroomrs==0.1.4
-wcwidth==0.2.10
+wcwidth==0.2.13
 xmlsec==1.3.14
 zstandard==0.18.0
 

requirements-getsentry.txt

@@ -11,4 +11,4 @@ iso3166
 pycountry==17.5.14
 pyvat==1.3.15
 reportlab==4.4.0
-stripe==5.5.0
+stripe==6.7.0