Skip to content

Commit eb0ae0b

Browse files
bruno-garciaandrewshie-sentry
authored andcommitted
add default symbol server for game engines (#91796)
1 parent 5176ac2 commit eb0ae0b

File tree

2 files changed

+48
-4
lines changed

2 files changed

+48
-4
lines changed

src/sentry/api/helpers/default_symbol_sources.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44
DEFAULT_SYMBOL_SOURCES = {
55
"electron": ["ios", "microsoft", "electron"],
66
"javascript-electron": ["ios", "microsoft", "electron"],
7-
"unity": ["unity"],
7+
"unity": ["unity", "nvidia", "ubuntu"],
8+
"unreal": ["nvidia", "ubuntu"],
9+
"godot": ["nvidia", "ubuntu"],
810
}
911

1012

tests/sentry/api/endpoints/test_team_projects.py

Lines changed: 45 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -368,8 +368,8 @@ def test_builtin_symbol_sources_not_electron(self):
368368

369369
def test_builtin_symbol_sources_unity(self):
370370
"""
371-
Test that project option for builtin symbol sources contains ["unity"] when creating
372-
a Unity project, but uses defaults for other platforms.
371+
Test that project option for builtin symbol sources contains relevant buckets
372+
when creating a Unity project, but uses defaults for other platforms.
373373
"""
374374
response = self.get_success_response(
375375
self.organization.slug,
@@ -385,7 +385,49 @@ def test_builtin_symbol_sources_unity(self):
385385
symbol_sources = ProjectOption.objects.get_value(
386386
project=unity_project, key="sentry:builtin_symbol_sources"
387387
)
388-
assert symbol_sources == ["unity"]
388+
assert symbol_sources == ["unity", "nvidia", "ubuntu"]
389+
390+
def test_builtin_symbol_sources_unreal(self):
391+
"""
392+
Test that project option for builtin symbol sources contains relevant buckets
393+
when creating a Unreal project, but uses defaults for other platforms.
394+
"""
395+
response = self.get_success_response(
396+
self.organization.slug,
397+
self.team.slug,
398+
name="unreal-app",
399+
slug="unreal-app",
400+
platform="unreal",
401+
status_code=201,
402+
)
403+
404+
unreal_project = Project.objects.get(id=response.data["id"])
405+
assert unreal_project.platform == "unreal"
406+
symbol_sources = ProjectOption.objects.get_value(
407+
project=unreal_project, key="sentry:builtin_symbol_sources"
408+
)
409+
assert symbol_sources == ["nvidia", "ubuntu"]
410+
411+
def test_builtin_symbol_sources_godot(self):
412+
"""
413+
Test that project option for builtin symbol sources contains relevant buckets
414+
when creating a Godot project, but uses defaults for other platforms.
415+
"""
416+
response = self.get_success_response(
417+
self.organization.slug,
418+
self.team.slug,
419+
name="godot-app",
420+
slug="godot-app",
421+
platform="godot",
422+
status_code=201,
423+
)
424+
425+
godot_project = Project.objects.get(id=response.data["id"])
426+
assert godot_project.platform == "godot"
427+
symbol_sources = ProjectOption.objects.get_value(
428+
project=godot_project, key="sentry:builtin_symbol_sources"
429+
)
430+
assert symbol_sources == ["nvidia", "ubuntu"]
389431

390432
@patch("sentry.api.endpoints.team_projects.TeamProjectsEndpoint.create_audit_entry")
391433
def test_create_project_with_origin(self, create_audit_entry):

0 commit comments

Comments
 (0)