fix(new-trace-url) Updated node path encoding. (#68458)

Abdkhan14 · Abdullah Khan · web-flow · commit eb5ecf73121b · 2024-04-08T22:59:05.000-04:00
Trace view page expects `[`span-${spanId}`, `txn-${eventId}`]` to look
for and scroll to span but we were passing [`span:${spanId}`,
`txn:${eventId}`]

Co-authored-by: Abdullah Khan &lt;abdullahkhan@PG9Y57YDXQ.local&gt;
diff --git a/static/app/views/performance/traceDetails/utils.tsx b/static/app/views/performance/traceDetails/utils.tsx
@@ -35,7 +35,7 @@ export function getTraceDetailsUrl(
 
   if (organization.features.includes('trace-view-v1')) {
     if (spanId) {
-      queryParams.node = [`span:${spanId}`, `txn:${eventId}`];
+      queryParams.node = [`span-${spanId}`, `txn-${eventId}`];
     }
     return {
       pathname: normalizeUrl(

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ export function getTraceDetailsUrl(`
`35`	`35`
`36`	`36`	`if (organization.features.includes('trace-view-v1')) {`
`37`	`37`	`if (spanId) {`
`38`		- queryParams.node = [`span:${spanId}`, `txn:${eventId}`];
	`38`	+ queryParams.node = [`span-${spanId}`, `txn-${eventId}`];
`39`	`39`	`}`
`40`	`40`	`return {`
`41`	`41`	`pathname: normalizeUrl(`