Skip to content

Commit ed93acf

Browse files
Abdkhan14Abdullah Khan
and
Abdullah Khan
authored
flag(new-trace): Using new explore flag for all traceview actions routing to explore (#89663)
I'll be removing the `trace-drawer-action` flag Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
1 parent e9bb1a5 commit ed93acf

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

static/app/components/events/eventTags/eventTagsTreeRow.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ function EventTagsTreeRowDropdown({
131131
const location = useLocation();
132132
const hasNewTraceUi = useHasTraceNewUi();
133133
const organization = useOrganization();
134-
const hasTraceDrawerAction = organization.features.includes('trace-drawer-action');
134+
const hasExploreEnabled = organization.features.includes('visibility-explore-view');
135135
const {onClick: handleCopy} = useCopyToClipboard({
136136
text: content.value,
137137
});
@@ -196,7 +196,7 @@ function EventTagsTreeRowDropdown({
196196
},
197197
];
198198

199-
if (hasNewTraceUi && hasTraceDrawerAction) {
199+
if (hasNewTraceUi && hasExploreEnabled) {
200200
items.push({
201201
key: 'view-traces',
202202
label: t('Find more samples with this value'),

static/app/views/performance/newTraceDetails/traceActionsMenu.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ function TraceActionsMenu({
3838
const organization = useOrganization();
3939
const {projects} = useProjects();
4040
const navigate = useNavigate();
41-
const hasDrawerAction = organization.features.includes('trace-drawer-action');
41+
const hasExploreEnabled = organization.features.includes('visibility-explore-view');
4242

4343
if (!hasTraceNewUi) {
4444
return null;
@@ -53,13 +53,13 @@ function TraceActionsMenu({
5353
items={[
5454
{
5555
key: 'open_trace_events',
56-
label: hasDrawerAction
56+
label: hasExploreEnabled
5757
? t('Open Events in Explore')
5858
: t('Open Events in Discover'),
5959
onAction: () => {
6060
let target;
6161

62-
if (hasDrawerAction) {
62+
if (hasExploreEnabled) {
6363
const key = 'trace';
6464
const value = traceSlug ?? '';
6565

static/app/views/performance/newTraceDetails/traceDrawer/details/span/sections/description.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export function SpanDescription({
8080
}) {
8181
const hasTraceNewUi = useHasTraceNewUi();
8282
const span = node.value;
83-
const hasTraceDrawerAction = organization.features.includes('trace-drawer-action');
83+
const hasExploreEnabled = organization.features.includes('visibility-explore-view');
8484
const resolvedModule: ModuleName = resolveSpanModule(
8585
span.sentry_tags?.op,
8686
span.sentry_tags?.category
@@ -121,7 +121,7 @@ export function SpanDescription({
121121
const groupHash = hasNewSpansUIFlag
122122
? (span.sentry_tags?.group ?? '')
123123
: (span.hash ?? '');
124-
const showAction = hasTraceDrawerAction ? !!span.description : !!span.op && !!span.hash;
124+
const showAction = hasExploreEnabled ? !!span.description : !!span.op && !!span.hash;
125125
const averageSpanDuration: number | undefined =
126126
span['span.averageResults']?.['avg(span.duration)'];
127127

@@ -134,7 +134,7 @@ export function SpanDescription({
134134
<SpanSummaryLink event={node.event!} organization={organization} span={span} />
135135
<Link
136136
to={
137-
hasTraceDrawerAction
137+
hasExploreEnabled
138138
? getSearchInExploreTarget(
139139
organization,
140140
location,
@@ -152,7 +152,7 @@ export function SpanDescription({
152152
})
153153
}
154154
onClick={() => {
155-
if (hasTraceDrawerAction) {
155+
if (hasExploreEnabled) {
156156
traceAnalytics.trackExploreSearch(
157157
organization,
158158
SpanIndexedField.SPAN_DESCRIPTION,
@@ -175,7 +175,7 @@ export function SpanDescription({
175175
}}
176176
>
177177
<StyledIconGraph type="scatter" size="xs" />
178-
{hasNewSpansUIFlag || hasTraceDrawerAction
178+
{hasNewSpansUIFlag || hasExploreEnabled
179179
? t('More Samples')
180180
: t('View Similar Spans')}
181181
</Link>

static/app/views/performance/newTraceDetails/traceDrawer/details/styles.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -746,12 +746,12 @@ function KeyValueAction({
746746
const location = useLocation();
747747
const organization = useOrganization();
748748
const hasNewTraceUi = useHasTraceNewUi();
749-
const hasTraceDrawerAction = organization.features.includes('trace-drawer-action');
749+
const hasExploreEnabled = organization.features.includes('visibility-explore-view');
750750
const [isVisible, setIsVisible] = useState(false);
751751

752752
if (
753753
!hasNewTraceUi ||
754-
!hasTraceDrawerAction ||
754+
!hasExploreEnabled ||
755755
!defined(rowValue) ||
756756
!defined(rowKey) ||
757757
!['string', 'number'].includes(typeof rowValue)

0 commit comments

Comments
 (0)