Skip to content

Commit eefa8db

Browse files
authored
fix(taskworker) Don't send project to find_channel_id_for_rule (#91848)
Continues #91810 by changing the call sites to not pass `project` anymore.
1 parent b490ef4 commit eefa8db

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/sentry/api/endpoints/project_rule_details.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ def put(self, request: Request, project, rule) -> Response:
244244
kwargs = {
245245
"name": data["name"],
246246
"environment": data.get("environment"),
247-
"project": project,
247+
"project": None,
248248
"project_id": project.id,
249249
"action_match": data["actionMatch"],
250250
"filter_match": data.get("filterMatch"),

src/sentry/api/endpoints/project_rules.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -799,7 +799,7 @@ def post(self, request: Request, project) -> Response:
799799
kwargs = {
800800
"name": data["name"],
801801
"environment": data.get("environment"),
802-
"project": project,
802+
"project": None,
803803
"project_id": project.id,
804804
"action_match": data["actionMatch"],
805805
"filter_match": data.get("filterMatch"),

tests/sentry/api/endpoints/test_project_rules.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -727,6 +727,7 @@ def test_kicks_off_slack_async_job(
727727
payload["actions"][0].pop("name")
728728
kwargs = {
729729
"name": payload["name"],
730+
"project": None,
730731
"project_id": self.project.id,
731732
"environment": payload.get("environment"),
732733
"action_match": payload["actionMatch"],
@@ -739,7 +740,6 @@ def test_kicks_off_slack_async_job(
739740
"uuid": "abc123",
740741
}
741742
call_args = mock_find_channel_id_for_alert_rule.call_args[1]["kwargs"]
742-
assert call_args.pop("project").id == self.project.id
743743
assert call_args == kwargs
744744

745745
def test_comparison_condition(self):

0 commit comments

Comments
 (0)