Add empty state for no personal views

Author: MichaelSun48

static/app/utils/analytics/issueAnalyticsEvents.tsx

@@ -337,6 +337,7 @@ export type IssueEventParameters = {
     surface: 'issue-views-list' | 'issue-view-details';
   };
   'issue_views.switched_views': Record<string, unknown>;
+  'issue_views.table.banner_create_view_clicked': Record<string, unknown>;
   'issue_views.table.create_view_clicked': Record<string, unknown>;
   'issue_views.table.search': {
     query: string;
@@ -525,6 +526,8 @@ export const issueEventMap: Record<IssueEventKey, string | null> = {
   'issue_views.page_filters_logged': 'Issue Views: Page Filters Logged',
   'issue_views.table.sort_changed': 'Issue Views: Changed Sort',
   'issue_views.table.create_view_clicked': 'Issue Views: Create View Clicked',
+  'issue_views.table.banner_create_view_clicked':
+    'Issue Views: Create View Clicked from No Views Banner',
   'issue_views.new_view.suggested_query_clicked': 'Issue Views: Suggested Query Clicked',
   'issue_views.edit_name': 'Issue Views: Edit Name',
   'issue_views.star_view': 'Issue Views: Star View',

static/app/views/issueList/issueViews/issueViewSaveButton.tsx

@@ -3,9 +3,12 @@ import styled from '@emotion/styled';
 
 import {addSuccessMessage} from 'sentry/actionCreators/indicator';
 import {openModal} from 'sentry/actionCreators/modal';
+import Feature from 'sentry/components/acl/feature';
+import FeatureDisabled from 'sentry/components/acl/featureDisabled';
 import {Button} from 'sentry/components/core/button';
 import {ButtonBar} from 'sentry/components/core/button/buttonBar';
 import {DropdownMenu} from 'sentry/components/dropdownMenu';
+import {Hovercard} from 'sentry/components/hovercard';
 import {IconChevron} from 'sentry/icons';
 import {t} from 'sentry/locale';
 import {space} from 'sentry/styles/space';
@@ -77,52 +80,72 @@ function SegmentedIssueViewSaveButton({
   };
 
   return (
-    <ButtonBar merged>
-      <PrimarySaveButton
-        priority={buttonPriority}
-        data-test-id={hasUnsavedChanges ? 'save-button-unsaved' : 'save-button'}
-        onClick={() => {
-          if (canEdit) {
-            saveView();
-          } else {
-            openCreateIssueViewModal();
+    <Feature
+      features={['organizations:issue-views']}
+      hookName="feature-disabled:issue-views"
+      renderDisabled={props => (
+        <Hovercard
+          body={
+            <FeatureDisabled
+              features={props.features}
+              hideHelpToggle
+              featureName={t('Multiple Project Selection')}
+            />
           }
-        }}
-        disabled={isSaving}
-      >
-        {canEdit ? t('Save') : t('Save As')}
-      </PrimarySaveButton>
-      <DropdownMenu
-        items={[
-          {
-            key: 'reset',
-            label: t('Reset'),
-            disabled: !hasUnsavedChanges,
-            onAction: () => {
-              discardUnsavedChanges();
-            },
-          },
-          {
-            key: 'save-as',
-            label: t('Save as new view'),
-            onAction: () => {
-              openCreateIssueViewModal();
-            },
-            hidden: !canEdit,
-          },
-        ]}
-        trigger={props => (
-          <DropdownTrigger
-            {...props}
-            disabled={isSaving}
-            icon={<IconChevron direction="down" />}
-            aria-label={t('More save options')}
+        >
+          {typeof props.children === 'function' ? props.children(props) : props.children}
+        </Hovercard>
+      )}
+    >
+      {({hasFeature}) => (
+        <ButtonBar merged>
+          <PrimarySaveButton
             priority={buttonPriority}
+            data-test-id={hasUnsavedChanges ? 'save-button-unsaved' : 'save-button'}
+            onClick={() => {
+              if (canEdit) {
+                saveView();
+              } else {
+                openCreateIssueViewModal();
+              }
+            }}
+            disabled={!hasFeature || isSaving}
+          >
+            {canEdit ? t('Save') : t('Save As')}
+          </PrimarySaveButton>
+          <DropdownMenu
+            items={[
+              {
+                key: 'reset',
+                label: t('Reset'),
+                disabled: !hasUnsavedChanges,
+                onAction: () => {
+                  discardUnsavedChanges();
+                },
+              },
+              {
+                key: 'save-as',
+                label: t('Save as new view'),
+                onAction: () => {
+                  openCreateIssueViewModal();
+                },
+                hidden: !canEdit,
+              },
+            ]}
+            trigger={props => (
+              <DropdownTrigger
+                {...props}
+                disabled={isSaving}
+                icon={<IconChevron direction="down" />}
+                aria-label={t('More save options')}
+                priority={buttonPriority}
+              />
+            )}
+            position="bottom-end"
           />
-        )}
-        position="bottom-end"
-      />
-    </ButtonBar>
+        </ButtonBar>
+      )}
+    </Feature>
   );
 }