Skip to content

Commit f00ca17

Browse files
fix(codecov): Small review revisions
1 parent 13e132f commit f00ca17

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

static/app/views/codecov/tests/onboardingSteps/outputCoverageFile.tsx

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export function OutputCoverageFile({stepString}: OutputCoverageFileProps) {
4545
supported: (
4646
// TODO: the new version of this link is still TBD
4747
<Link to="https://docs.codecov.com/docs/test-analytics#:~:text=Only%20JUnit%20XML%20test%20result%20files%20are%20supported%20at%20the%20moment">
48-
supported languages
48+
{t('supported languages')}
4949
</Link>
5050
),
5151
}
@@ -62,17 +62,19 @@ export function OutputCoverageFile({stepString}: OutputCoverageFileProps) {
6262
value={selectedFramework}
6363
onChange={(option: {value: Frameworks}) => setSelectedFramework(option.value)}
6464
/>
65-
<StyledP>{t('Install requirements in your terminal:')}</StyledP>
65+
<StyledInstruction>
66+
{t('Install requirements in your terminal:')}
67+
</StyledInstruction>
6668
<CodeSnippet dark language="bash">
6769
{INSTALL_REQUIREMENTS_SNIPPETS[selectedFramework]}
6870
</CodeSnippet>
69-
{GENERATE_FILE_SNIPPETS[selectedFramework] ? (
71+
{selectedFramework === 'pytest' ? (
7072
<Fragment>
71-
<StyledP>
73+
<StyledInstruction>
7274
{t('Generate a JUnit XML file that contains the results of your test run.')}
73-
</StyledP>
75+
</StyledInstruction>
7476
<CodeSnippet dark language="bash">
75-
{GENERATE_FILE_SNIPPETS[selectedFramework]}
77+
{GENERATE_FILE_SNIPPETS.pytest}
7678
</CodeSnippet>
7779
</Fragment>
7880
) : null}
@@ -86,6 +88,6 @@ const StyledSelectControl = styled(Select)`
8688
margin-bottom: ${space(1.5)};
8789
`;
8890

89-
const StyledP = styled('p')`
91+
const StyledInstruction = styled('p')`
9092
margin: ${space(1.5)} 0;
9193
`;

0 commit comments

Comments
 (0)