Skip to content

Commit f980137

Browse files
authored
fix(insights): Left-align response status code column (#71124)
Do not treat that column as numeric! It's only numeric -ish since because 1. Sometimes it's "Unknown" which is literally not a number 2. The actual numbers have specific significance, unlike a count 3. All the numbers are always 3 digits anyway Left-alignment is a better fit here.
1 parent 0a989a8 commit f980137

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

static/app/utils/discover/fieldRenderers.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -698,13 +698,13 @@ const SPECIAL_FIELDS: SpecialFields = {
698698
'span.status_code': {
699699
sortField: 'span.status_code',
700700
renderFunc: data => (
701-
<NumberContainer>
701+
<Container>
702702
{data['span.status_code'] ? (
703703
<ResponseStatusCodeCell code={parseInt(data['span.status_code'], 10)} />
704704
) : (
705705
t('Unknown')
706706
)}
707-
</NumberContainer>
707+
</Container>
708708
),
709709
},
710710
};

static/app/views/starfish/components/tableCells/renderHeadCell.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ export const SORTABLE_FIELDS = new Set([
6767
const NUMERIC_FIELDS = new Set([
6868
'transaction.duration',
6969
SpanMetricsField.CACHE_ITEM_SIZE,
70-
SpanIndexedField.RESPONSE_CODE,
7170
SpanIndexedField.SPAN_SELF_TIME,
7271
SpanIndexedField.SPAN_DURATION,
7372
SpanIndexedField.CACHE_ITEM_SIZE,

0 commit comments

Comments
 (0)