🐛 fix(aci): fix sentry app action handling for test notifications and action handling #91306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
iamrajjoshi
commented
May 8, 2025
| id = get_key_from_rule_data(f.rule, "workflow_id") | ||
| # Ignore test notifications | ||
| if int(id) != -1: | ||
| if features.has("organizations:workflow-engine-ui-links", event.group.organization): |
There was a problem hiding this comment.
flipped the order so it actually does what its suppose to
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #91306 +/- ##
===========================================
+ Coverage 68.69% 87.65% +18.95%
===========================================
Files 10316 10320 +4
Lines 585531 585631 +100
Branches 22613 22613
===========================================
+ Hits 402259 513318 +111059
+ Misses 182844 71885 -110959
Partials 428 428 |
GabeVillalobos
approved these changes
May 8, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
… action handling (#91306)
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes 2 bugs
rule_idin test notifications b/c its -1isinstancecheck when invoking the noa since we can have integer values in sentry apps.