Skip to content

fix(crons): Floor seconds / microsecond on recorded dateClock #91890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

evanpurkhiser
Copy link
Member

We record this value for check-ins, this is supposed to be trimmed of
it's seconds and microseconds, since we count clock ticks in minutes

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner May 19, 2025 19:44
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 19, 2025
Copy link

codecov bot commented May 19, 2025

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:157341 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml

We record this value for check-ins, this is supposed to be trimmed of
it's seconds and microseconds, since we count clock ticks in minutes
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/fix-crons-floor-seconds-microsecond-on-recorded-dateclock branch from 0fc40d6 to 4edc455 Compare May 19, 2025 23:41
@evanpurkhiser evanpurkhiser merged commit ada6942 into master May 19, 2025
60 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/fix-crons-floor-seconds-microsecond-on-recorded-dateclock branch May 19, 2025 23:59
jan-auer added a commit that referenced this pull request May 20, 2025
* master: (58 commits)
  link: cleanup link (#91687)
  ref: create project_id index for organizationonboardingtask (#91918)
  storybook: smaller last edited (#91875)
  issues: fix chonk stacktrace alignment (#91891)
  alert: drop custom alert (#91892)
  insights: fix bar height (#91895)
  ref(span-buffer): Move max-memory-percentage to right CLI (#91924)
  ref(js): Factor button functionality (#91763)
  tests(resolve_groups): Clean up the tests (#91779)
  ref(span-buffer): Add backpressure (#91707)
  fix(nextjs-insights): project id is not passed to explore link (#91920)
  fix(crons): Floor seconds / microsecond on recorded dateClock (#91890)
  fix(uptime): Fix bug with the uptime_checks dataset in the events endpoint (#91824)
  ref: add state-only migration to reflect existing indexes in prod (#91901)
  ref: remove unnecssary metaclass (#91906)
  fix(stats): use data category title name (#91913)
  feat(issues): Add success messages to some actions (#91899)
  test(taskworker): Lower exec time (#91907)
  chore(aci): manually add spans for delayed workflow processing (#91908)
  chore(aci): remove uses of WorkflowFireHistory rollout columns (#91904)
  ...
andrewshie-sentry pushed a commit that referenced this pull request May 20, 2025
We record this value for check-ins, this is supposed to be trimmed of
it's seconds and microseconds, since we count clock ticks in minutes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants