chore(github): Add business+ plan check for multi org #91905
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Christinarlong
changed the title
| FeatureDescription( | ||
| """ | ||
| Connect multiple Sentry organizations to a single GitHub account. | ||
| """, | ||
| IntegrationFeatures.SCM_MULTI_ORG, | ||
| ), |
There was a problem hiding this comment.
do we usually feature flag adding this feature description? I was looking at some other PRs that added FeatureDescriptions and they weren't ever feature flagged (??)
There was a problem hiding this comment.
i'm okay waiting until GA to add this, since it's not available to everyone and will show up on the GH integration features page
There was a problem hiding this comment.
removed listing the feature in the integration page, we'll do this at GA time
| @@ -936,7 +951,10 @@ def dispatch(self, request: HttpRequest, pipeline: Pipeline) -> HttpResponseBase | |||
| return self.render_react_view( | |||
| request=request, | |||
| pipeline_name="githubInstallationSelect", | |||
| props={"installation_info": installation_info}, | |||
| props={ | |||
| "installation_info": installation_info, | |||
There was a problem hiding this comment.
if they don't have multi org, should we still be passing the full list of installations to the FE?
There was a problem hiding this comment.
i think we should also error if somebody tries to pass a chosen installation id that's not -1 and they don't have multi org
There was a problem hiding this comment.
For the passing the full list comment, I think it's useful to keep in case we want to do the per gh org upsell in the dropdown in the UI.
| features.has( | ||
| "organizations:integrations-scm-multi-org", | ||
| organization=self.active_user_organization.organization, | ||
| actor=request.user, |
There was a problem hiding this comment.
qq: whats the purpose of passing user here?
There was a problem hiding this comment.
🤔 I probably yoinked this from a previous feature flag checker, but looking further yeah we dont need to be passing the user/it wont be used.
This PR
organizations:integrations-scm-multi-orgflag to the permanent list of feature flags (there is a getsentry PR too to add the flag to business plans)chosen_installation_id(validate the user has access to multi-org feature)Instead of having multiple conditions for the
organizations:github-multi-orgflag, we will use theorganizations:integrations-scm-multi-orgto validate that the feature can only be accessed by business+ plans andorganizations:github-multi-orgwill control which orgs can access the feature.PR for FF in plans for getsentry: https://github.com/getsentry/getsentry/pull/17517
PR for UI changes: #92036