-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Support for Python SDK 3.0.0 #92011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
antonpirker
wants to merge
25
commits into
master
Choose a base branch
from
antonpirker/code-changes-for-sdk-3.0.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Support for Python SDK 3.0.0 #92011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…debase and also gone in SDK 3.0
❌ 119 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[work in progress]
Sentry SDK
3.0.0
has massive changes on how the data flows through the SDK compared to2.x
. (3.0 uses Opentelementry under the hood to create spans)Some APIs in 3.0 is not backwards compatible with 2.x so we need to change a lot of call sites.
Still ToDo (not an exhaustive list):
custom_sampling_context
everywhere in code base (given to spans)TODO-anton
in PR files changed)What this PR does:
propagate_hub=True
fromThreadingIntegration
@mmetrics_noop
decorator, because there are no metrics anymore onlyspan.data
, so we do not need it.sampled=False
from assigning to a span into thestart_span()
call.span.set_data
withspan.set_attribute
with the same paramsscope.add_attachment
tosentry_sdk.add_attachment
.start_transaction()
to.start_span()
(without ever settingonly_if_parent
)custom_sampling_context
param in.start_span()
toattributes
continue_trace
to the new context manager.src/sentry/utils/sdk.py::set_measurement()
because it is not used insentry
.scope.transaction
withscope.root_span
sentry_sdk.Scope.get_*_scope()
withsentry_sdk.get_*_scope()