fix(processing): Don't pretend to log 'not_sent' #92050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
|
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/sentry/rules/processing/delayed_processing.py | 0.00% | 1 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## master #92050 +/- ##
===========================================
+ Coverage 41.73% 87.86% +46.12%
===========================================
Files 10140 10167 +27
Lines 581783 582850 +1067
Branches 22592 22592
===========================================
+ Hits 242816 512128 +269312
+ Misses 338546 70301 -268245
Partials 421 421 
saponifi3d
approved these changes
May 21, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
Stop tracking/logging `not_sent` based on callback return value being None; callback return value is always expected to be `None`, not just on exception, so logging it as `not_sent` is misleading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop tracking/logging
not_sentbased on callback return value being None; callback return value is always expected to beNone, not just on exception, so logging it asnot_sentis misleading.