fix(uptime): Don't consume a seat or create audit log when onboarding an auto detected monitor #92051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92051 +/- ##
=======================================
Coverage 87.89% 87.90%
=======================================
Files 10226 10226
Lines 585974 585986 +12
Branches 22760 22760
=======================================
+ Hits 515068 515084 +16
+ Misses 70477 70473 -4
Partials 429 429 |
wedamija
force-pushed
the
danf/uptime-disable-autodetection-on-manual-creation
branch
from
92b3be9 to
b96c17d
Compare
evanpurkhiser
approved these changes
May 28, 2025
Base automatically changed from
danf/uptime-disable-autodetection-on-manual-creation
to
master
May 28, 2025 20:53
… an auto detected monitor Users don't see onboarding monitors, and so they shouldn't consume a quota seat or create an audit log. This pr moves this to the point where the monitor graduates from onboarding.
wedamija
force-pushed
the
danf/uptime-onboarding-dont-consume-seat-audit
branch
from
309d31c to
6bf5126
Compare
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
… an auto detected monitor (#92051) Users don't see onboarding monitors, and so they shouldn't consume a quota seat or create an audit log. This pr moves this to the point where the monitor graduates from onboarding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users don't see onboarding monitors, and so they shouldn't consume a quota seat or create an audit log. This pr moves this to the point where the monitor graduates from onboarding.