-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(ourlogs): Add infinite table and auto refresh #92059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
k-fish
wants to merge
14
commits into
master
Choose a base branch
from
feat/ourlogs/auto-refresh-and-infinite-table
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a virtualized table behind a new feature flag (ourlogs-live-refresh). This has a max number of pages (10, ~0-10k log lines stored) and a virtualization that likely needs to be tuned for render performance before turning it on for users. The logs infinite table is currently a completely separate table only used behind the feature flag, using tanstack virtual and tanstack infinite query.
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
…efresh-and-infinite-table
colin-sentry
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a virtualized table behind a new feature flag (ourlogs-live-refresh). This has a max number of pages (10, ~0-10k log lines stored) and a virtualization that likely needs to be tuned for render performance before turning it on for users.
The logs infinite table is currently a completely separate table only used behind the feature flag, using tanstack virtual and tanstack infinite query. The auto-refreshing refreshes the page behind the ingest delay (a period in which the data may be incomplete) to avoid having to collate results, fetches large pages (up to 1000 resultss) and a virtual time is moved forwards at ~3fps to simulate streaming of that data on the frontend.
Virtual Streaming
Other
useLogsQuery
with the newuseApiQuery
, which might introduce some subtle differences, but so far removes strange bugs like theenabled:
tri-state boolean bug.useInfiniteQuery
does basically the same and can re-use the query-key to reduce bugs between the two.LogsFixture
to correctly create a log item in testsFuture work