Skip to content

🔧 chore: classify vsts identity deleted errors as halt #92078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

iamrajjoshi
Copy link
Member

we get a lot of errors like

sentry.shared_integrations.exceptions.ApiError: According to Microsoft Entra, your Identity xxx is currently Deleted within the following Microsoft Entra tenant: xxx Please contact your Microsoft Entra administrator to resolve this

these errors need to be halts, and a more accurate exception type would be ApiUnauthorized

@iamrajjoshi iamrajjoshi self-assigned this May 21, 2025
@iamrajjoshi iamrajjoshi requested review from a team as code owners May 21, 2025 22:16
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 21, 2025
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:156309 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Files with missing lines Patch % Lines
src/sentry/integrations/utils/metrics.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #92078      +/-   ##
==========================================
+ Coverage   79.18%   82.75%   +3.57%     
==========================================
  Files       10168    10168              
  Lines      582909   582935      +26     
  Branches    22596    22596              
==========================================
+ Hits       461565   482429   +20864     
+ Misses     120056    99218   -20838     
  Partials     1288     1288              

@iamrajjoshi iamrajjoshi merged commit ac0ceb4 into master May 22, 2025
61 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/classify-identity-deleted-as-halt branch May 22, 2025 17:21
Copy link

sentry-io bot commented May 23, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ IntegrationError: Error Communicating with Azure DevOps (HTTP 400): TF401324: Value for field 'System.Title' is too long. /api/0/organizations/{organization_id_or_slug}/... View Issue
  • ‼️ IntegrationError: Error Communicating with Azure DevOps (HTTP 400): TF401320: Rule Error for field Plateform. Error code: Required, HasValues, LimitedToValues, AllowsOldValue, InvalidEmpty. 5 additional errors occurred during validation of the work item. Please correct a... sentry.tasks.post_process.post_process_group View Issue
  • ‼️ ApiError: {"$id":"1","innerException":null,"message":"VS800075: The project with id '3e6b3707-7477-49c3-b893-f10e64852a0f' does not exist, or you do not have permission to access it.","typeName":"Microsoft.TeamFoundation.Core.WebApi.ProjectDoesNotExistException, ... sentry.tasks.post_process.post_process_group View Issue
  • ‼️ IntegrationError: Error Communicating with Azure DevOps (HTTP 404): VS800075: The project with id '3e6b3707-7477-49c3-b893-f10e64852a0f' does not exist, or you do not have permission to access it. sentry.tasks.post_process.post_process_group View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants