Skip to content

fix(taskworker) Remove high-throughput setting #92158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markstory
Copy link
Member

We added this setting when options checks for taskworkers were expensive (because we used isset()), now that we've made option reads cheaper via get(), we shouldn't need this setting.

We added this setting when options checks for taskworkers were
expensive (because we used isset()), now that we've made option reads
cheaper via get(), we shouldn't need this setting.
@markstory markstory requested a review from a team May 22, 2025 20:26
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 22, 2025
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:156615 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #92158    +/-   ##
========================================
  Coverage   87.86%   87.86%            
========================================
  Files       10179    10179            
  Lines      583224   583397   +173     
  Branches    22605    22605            
========================================
+ Hits       512470   512623   +153     
- Misses      70302    70322    +20     
  Partials      452      452            

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants