Skip to content

ref(grouping): Switch to using split enhancements #92180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented May 23, 2025

This switches from using non-split enhancements (and sometimes also calculating split enhancements) to just using the split enhancements. In the time since the experiment was enabled, across over 150 million events, the results of the split enhancements have matched* those of the non-split ones, and the split enhancements have been running on average about 45% faster than the non-split ones.

image

  • To be more precise, they have matched except in cases where the split enhancements have given different/better hints, in ways we expect:
  • Because the rules are split, hints about marking things in-app or out of app only include the +/-app part of the rule, and hints about ignoring/unignoring only include the +/-group part.
  • In cases where both an in-app and contributes change have happened, both are now included in the hint.

This can be seen in the snapshot changes included in this PR.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 23, 2025
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #92180      +/-   ##
==========================================
- Coverage   87.90%   87.90%   -0.01%     
==========================================
  Files       10226    10226              
  Lines      585857   585807      -50     
  Branches    22752    22752              
==========================================
- Hits       515016   514952      -64     
- Misses      70412    70426      +14     
  Partials      429      429              

@lobsterkatie lobsterkatie force-pushed the kmclb-switch-to-split-enhancements branch from d3b4dd5 to 42f32bc Compare May 28, 2025 18:45
@lobsterkatie lobsterkatie marked this pull request as ready for review May 28, 2025 19:15
@lobsterkatie lobsterkatie requested review from a team as code owners May 28, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants