-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref(grouping): Switch to using split enhancements #92180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lobsterkatie
wants to merge
9
commits into
master
Choose a base branch
from
kmclb-switch-to-split-enhancements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92180 +/- ##
==========================================
- Coverage 87.90% 87.90% -0.01%
==========================================
Files 10226 10226
Lines 585857 585807 -50
Branches 22752 22752
==========================================
- Hits 515016 514952 -64
- Misses 70412 70426 +14
Partials 429 429 |
123bdfa
to
d3b4dd5
Compare
d3b4dd5
to
42f32bc
Compare
armenzg
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from using non-split enhancements (and sometimes also calculating split enhancements) to just using the split enhancements. In the time since the experiment was enabled, across over 150 million events, the results of the split enhancements have matched* those of the non-split ones, and the split enhancements have been running on average about 45% faster than the non-split ones.
+/-app
part of the rule, and hints about ignoring/unignoring only include the+/-group
part.This can be seen in the snapshot changes included in this PR.