fix(ourlogs): Allow multiple traces #92220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Span attribute definitions were updated but not logs, this allows multiple event ids to be sent in a list form as a generic validator. Adds a test.
github-actions
bot
added
the
Scope: Backend
wmak
approved these changes
May 23, 2025
Zylphrex
approved these changes
May 23, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #92220 +/- ##
==========================================
+ Coverage 85.57% 87.93% +2.36%
==========================================
Files 10172 10174 +2
Lines 583352 583386 +34
Branches 22594 22594
==========================================
+ Hits 499186 512992 +13806
+ Misses 83714 69942 -13772
Partials 452 452 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Span attribute definitions were updated but not logs, this allows multiple event ids to be sent in a list form as a generic validator. Adds a test.