Skip to content

feat(explore): Add equation support to the spans dataset #92354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wmak
Copy link
Member

@wmak wmak commented May 27, 2025

  • This updates the spans dataset to support equations in the same format that discover supports them today

- This updates the spans dataset to support equations in the same format
  that discover supports them today
@wmak wmak requested review from a team as code owners May 27, 2025 20:48
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 27, 2025
@wmak wmak marked this pull request as draft May 27, 2025 20:49
@wmak
Copy link
Member Author

wmak commented May 27, 2025

just checking CI

Copy link

codecov bot commented May 27, 2025

❌ 44 Tests Failed:

Tests completed Failed Passed Skipped
25981 44 25937 211
View the top 3 failed test(s) by shortest run time
tests.sentry.api.endpoints.test_organization_traces.OrganizationTracesEAPEndpointTest::test_use_separate_referrers
Stack Traces | 2.49s run time
#x1B[1m#x1B[.../api/endpoints/test_organization_traces.py#x1B[0m:2551: in test_use_separate_referrers
    assert response.status_code == 200, response.data
#x1B[1m#x1B[31mE   AssertionError: {'detail': 'Internal Error', 'errorId': None}#x1B[0m
#x1B[1m#x1B[31mE   assert 500 == 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m
tests.sentry.api.endpoints.test_organization_profiling_profiles.OrganizationProfilingFlamegraphTest::test_queries_profile_candidates_from_spans
Stack Traces | 3.13s run time
#x1B[1m#x1B[.../api/endpoints/test_organization_profiling_profiles.py#x1B[0m:898: in test_queries_profile_candidates_from_spans
    mock_proxy_profiling_service.assert_called_once_with(
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.1.../x64/lib/python3.13/unittest/mock.py#x1B[0m:988: in assert_called_once_with
    raise AssertionError(msg)
#x1B[1m#x1B[31mE   AssertionError: Expected 'proxy_profiling_service' to be called once. Called 0 times.#x1B[0m
tests.sentry.api.endpoints.test_organization_traces.OrganizationTracesEAPEndpointTest::test_use_first_span_for_name
Stack Traces | 3.83s run time
#x1B[1m#x1B[.../api/endpoints/test_organization_traces.py#x1B[0m:469: in test_use_first_span_for_name
    assert response.status_code == 200, response.data
#x1B[1m#x1B[31mE   AssertionError: {'detail': 'Internal Error', 'errorId': None}#x1B[0m
#x1B[1m#x1B[31mE   assert 500 == 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant