“IN” filter in alerts removes spaces, tag values with spaces don’t match

[dalnoki]

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

1. Create an Issue Alert in Sentry and add a condition:The event’s tags match domain is in (comma separated)
2. Enter a filter value containing a space (e.g. foo bar), and save the rule.
3. Send or capture an event in Sentry with a tag domain="foo bar".
4. Wait for the alert - the event will appear in the issues list, but the alert never triggers.

In contrast, if you change the filter to foobar (no space) and send an event tagged domain="foobar", the alert triggers as expected.

Alert rule: https://kismeow.sentry.io/alerts/rules/javascript-rea/16026550/details/
Issue: https://kismeow.sentry.io/issues/6653513404/distributions/?project=4505244102426624&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&stream_index=1

Sentry’s documentation on tags only prohibits spaces in tag keys, not values.

Code location:

sentry/src/sentry/rules/match.py

Line 95 in dc5165d

values_set = set(match_value.replace(" ", "").split(","))

Expected Result

The alert rule should trigger for these events as well

Actual Result

The alert rule doesn't trigger

Product Area

Alerts

Link

No response

DSN

No response

Version

No response

[getsantry]

Routing to @getsentry/product-owners-alerts for triage ⏲️

[getsantry]

Auto-routing to @getsentry/product-owners-alerts for triage ⏲️

[minori-fh]

Additional scenario/ issue with is in (comma separated) conditional in alert rule (ref ticket)

Created an issue with exception.value 'Load failed' and three alerts that should all trigger (however, only 3 is triggered):

1. Alert on exception.value is in (comma separated) 'Load failed,Load failed' (not triggered)
2. Alert on exception.value is in (comma separated) 'Load failed,Testing' (not triggered)
3. Alert on exception.value equals 'Load failed' (triggered)

All three alerts should be triggered.

[malwilley]

Thanks for the bug report (and the helpful pinpointing of code)! This is a real issue. It looks like originally, the removal of spaces allowed for typing something like a, b and it would filter for a and b. But we should really only be stripping whitespace from the ends, not from the middle.

I'll add this to the backlog and try to get in a fix now if it's not too much work.