Skip to content

feat: PowerShell support #66586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

vaind
Copy link
Contributor

@vaind vaind commented Mar 8, 2024

This adds a new SDK: PowerShell

I've implemented these changes by copying what is done for platform elixir.

I've tested the changes locally and everything seems to work fine AFAICT.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Mar 8, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 72.06%. Comparing base (8bc643a) to head (fceebb4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #66586      +/-   ##
==========================================
- Coverage   79.10%   72.06%   -7.04%     
==========================================
  Files        6534     6371     -163     
  Lines      290104   282231    -7873     
  Branches    48555    48555              
==========================================
- Hits       229473   203378   -26095     
- Misses      60191    77821   +17630     
- Partials      440     1032     +592     
Files Coverage Δ
src/sentry/models/featureadoption.py 95.80% <ø> (ø)
src/sentry/models/project.py 97.54% <ø> (ø)
src/sentry/utils/tag_normalization.py 100.00% <ø> (ø)
...s/interfaces/frame/usePrismTokensSourceContext.tsx 49.42% <ø> (-29.89%) ⬇️
static/app/data/platformCategories.tsx 100.00% <ø> (ø)
static/app/data/platformPickerCategories.tsx 100.00% <ø> (ø)
static/app/data/platforms.tsx 100.00% <ø> (ø)
static/app/utils/docs.tsx 54.54% <ø> (ø)
static/app/utils/fileExtension.tsx 100.00% <ø> (ø)
...c/app/gettingStartedDocs/powershell/powershell.tsx 66.66% <66.66%> (ø)

... and 1384 files with indirect coverage changes

@vaind vaind marked this pull request as ready for review March 11, 2024 11:07
@vaind vaind requested review from a team as code owners March 11, 2024 11:07
@vaind
Copy link
Contributor Author

vaind commented Mar 15, 2024

What do I need to do here to get this landed?

@ArthurKnaus
Copy link
Member

Hey @vaind, could you split this PR? FE / BE split should be good enough.
I can then review the FE one 🙂

@vaind
Copy link
Contributor Author

vaind commented Mar 24, 2024

Hey @vaind, could you split this PR? FE / BE split should be good enough. I can then review the FE one 🙂

I hope I got the split right:

thanks for the review

@vaind vaind closed this Mar 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants