Skip to content

feature - Enhancement for on-premise BitBucket Server integration #67063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

OldNavi
Copy link

@OldNavi OldNavi commented Mar 15, 2024

Hi,

Spend a bit of a time tuning self-hosted sentry installation to work with on-premise BitBucket server integration, not much things added, however I humbly hope you'll find this PR useful to make Sentry a bit more better software for self-hosted users.

Things added in PR:

  • StackTrace Link feature for BitBucket Server integration
  • Fix for repos not showing in multi-org setups if BitBucket servers integration are used in different orgs and repos already being used in another org.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@OldNavi OldNavi requested review from a team as code owners March 15, 2024 18:16
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Mar 15, 2024
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 84.27%. Comparing base (f6dedd9) to head (17969ee).
Report is 1519 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #67063      +/-   ##
==========================================
- Coverage   84.27%   84.27%   -0.01%     
==========================================
  Files        5307     5307              
  Lines      237295   237317      +22     
  Branches    41053    41053              
==========================================
+ Hits       199978   199992      +14     
- Misses      37099    37107       +8     
  Partials      218      218              
Files Coverage Δ
...ry/api/endpoints/organization_integration_repos.py 94.44% <100.00%> (ø)
static/app/utils/integrationUtil.tsx 66.66% <ø> (ø)
src/sentry/integrations/bitbucket_server/client.py 92.45% <66.66%> (-1.55%) ⬇️
...entry/integrations/bitbucket_server/integration.py 83.33% <41.17%> (-5.11%) ⬇️

... and 10 files with indirect coverage changes

@cathteng
Copy link
Member

hi, i just wanted to comment to let you know that this is on our radar

@OldNavi
Copy link
Author

OldNavi commented Mar 27, 2024

hi, i just wanted to comment to let you know that this is on our radar

Thanks!

@getsantry
Copy link
Contributor

getsantry bot commented Apr 18, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Apr 18, 2024
@getsantry getsantry bot closed this Apr 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants