-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
🤖 Optimize Snuba Query Size #67247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤖 Optimize Snuba Query Size #67247
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/sentry/utils/snuba.py
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #67247 +/- ##
===========================================
- Coverage 84.33% 68.43% -15.91%
===========================================
Files 5307 5305 -2
Lines 237145 236917 -228
Branches 41014 40981 -33
===========================================
- Hits 199990 162126 -37864
- Misses 36937 74567 +37630
- Partials 218 224 +6
|
It has a decent idea here - the implementation is bad, but the idea of auto splitting queries so we don't go over the max isn't bad. I'm not sure we'd commit such a wide ranging change (even if correctly implemented) without a lot of caution |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
👋 Hi there! This PR was automatically generated 🤖
Triggered by tillman.elser@sentry.io
Fixes SENTRY-2Z31
The issue is caused by a 'QuerySizeExceeded' exception indicating that the maximum query size was exceeded in a ClickHouse database operation. This happens when attempting to execute a query that is too large. To resolve this, we will implement a query size check before executing the query and split large queries into smaller chunks if necessary.
The steps that were performed:
📣 Instructions for the reviewer which is you, yes you:
This will greatly help us improve the autofix system. Thank you! 🙏
If there are any questions, please reach out to the AI/ML Team on #proj-autofix
🤓 Stats for the nerds:
Prompt tokens: 191577
Completion tokens: 4178
Total tokens: 195755