Skip to content

Keep GitHub Actions up to date with Dependabot #67345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 20, 2024

Fix warnings like at the bottom right of
https://github.com/getsentry/sentry/actions/runs/8361594088

https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@cclauss cclauss requested a review from a team as a code owner March 20, 2024 15:31
@asottile-sentry
Copy link
Member

we're currently only using dependabot for security updates and I don't think we really want to change that right now

@cclauss
Copy link
Contributor Author

cclauss commented Mar 20, 2024

Using unsupported versions of Node.js in multiple GitHub Actions is not a security concern?

@asottile-sentry
Copy link
Member

github issues the warning and then runs it with a supported version of node

@cclauss
Copy link
Contributor Author

cclauss commented Mar 20, 2024

Is that auto-upgrade documented somewhere?

@asottile-sentry
Copy link
Member

for instance:

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

@cclauss
Copy link
Contributor Author

cclauss commented Mar 20, 2024

Fascinating. Thanks. It means that Action code is running on a version of Node.js that it was probably not tested to run on.

@getsantry
Copy link
Contributor

getsantry bot commented Apr 11, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Apr 11, 2024
@getsantry getsantry bot closed this Apr 19, 2024
@cclauss cclauss deleted the patch-2 branch April 19, 2024 07:33
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants