Skip to content

feat: PowerShell support (frontend) #67576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 4, 2024

Conversation

vaind
Copy link
Contributor

@vaind vaind commented Mar 24, 2024

This adds a new SDK to the frontend: PowerShell

I've implemented these changes by copying what is done for platform elixir.

I've tested the changes locally and everything seems to work fine AFAICT.

backend PR: #67577

Resolves:

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@vaind vaind requested a review from a team as a code owner March 24, 2024 11:52
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 24, 2024
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.94%. Comparing base (4c32dd8) to head (f196987).

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #67576       +/-   ##
===========================================
- Coverage   88.05%   77.94%   -10.12%     
===========================================
  Files        2891     6571     +3680     
  Lines      179323   292602   +113279     
  Branches    32137    50522    +18385     
===========================================
+ Hits       157911   228062    +70151     
- Misses      15528    58290    +42762     
- Partials     5884     6250      +366     
Files Coverage Δ
...s/interfaces/frame/usePrismTokensSourceContext.tsx 79.31% <ø> (ø)
static/app/data/platformCategories.tsx 100.00% <ø> (ø)
static/app/data/platformPickerCategories.tsx 100.00% <ø> (ø)
static/app/data/platforms.tsx 100.00% <ø> (ø)
static/app/utils/docs.tsx 54.54% <ø> (ø)
static/app/utils/fileExtension.tsx 100.00% <ø> (ø)
...c/app/gettingStartedDocs/powershell/powershell.tsx 66.66% <66.66%> (ø)

... and 3673 files with indirect coverage changes

@vaind vaind mentioned this pull request Mar 24, 2024
Copy link
Member

@ArthurKnaus ArthurKnaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🙌
We will need to merge the BE PR first. Otherwise creating a powershell project will fail.

@ArthurKnaus ArthurKnaus added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Mar 26, 2024
JoshFerge added a commit that referenced this pull request Apr 3, 2024
<!-- Describe your PR here. -->
This adds a new SDK to the backend: PowerShell

I've implemented these changes by copying what is done for platform
elixir.

I've tested the changes locally and everything seems to work fine
AFAICT.

frontend PR: #67576
<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

---------

Co-authored-by: Josh Ferge <josh.ferge@gmail.com>
@bruno-garcia
Copy link
Member

the backend PR was merged so this is unblocked:

@github-actions github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Apr 4, 2024
Co-authored-by: ArthurKnaus <knauar@gmail.com>
shellmayr pushed a commit that referenced this pull request Apr 10, 2024
<!-- Describe your PR here. -->
This adds a new SDK to the backend: PowerShell

I've implemented these changes by copying what is done for platform
elixir.

I've tested the changes locally and everything seems to work fine
AFAICT.

frontend PR: #67576
<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

---------

Co-authored-by: Josh Ferge <josh.ferge@gmail.com>
Copy link
Member

@ArthurKnaus ArthurKnaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ArthurKnaus ArthurKnaus added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Apr 11, 2024
Co-authored-by: ArthurKnaus <knauar@gmail.com>
@github-actions github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Apr 11, 2024
@ArthurKnaus
Copy link
Member

linting is still failing:

/home/runner/work/sentry/sentry/README.md
  4:7  error  Parsing error: JSX element 'img' has no corresponding closing tag

@vaind
Copy link
Contributor Author

vaind commented Apr 16, 2024

linting is still failing:

/home/runner/work/sentry/sentry/README.md
  4:7  error  Parsing error: JSX element 'img' has no corresponding closing tag

that has nothing to do with the changes in the PR, it's broken on the main branch. It's just that the check runs because this PR changes the file (on other lines)

@ArthurKnaus ArthurKnaus added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Apr 25, 2024
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
@github-actions github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label May 2, 2024
@ArthurKnaus ArthurKnaus added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label May 21, 2024
@github-actions github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label May 28, 2024
@vaind
Copy link
Contributor Author

vaind commented May 29, 2024

Is there anything that needs to be done for this to get merged?

@ArthurKnaus ArthurKnaus added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jun 4, 2024
@ArthurKnaus ArthurKnaus merged commit b812f8c into getsentry:master Jun 4, 2024
42 of 44 checks passed
@vaind vaind deleted the feat/powershell-fe branch June 4, 2024 08:40
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants