-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: PowerShell support (frontend) #67576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #67576 +/- ##
===========================================
- Coverage 88.05% 77.94% -10.12%
===========================================
Files 2891 6571 +3680
Lines 179323 292602 +113279
Branches 32137 50522 +18385
===========================================
+ Hits 157911 228062 +70151
- Misses 15528 58290 +42762
- Partials 5884 6250 +366
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🙌
We will need to merge the BE PR first. Otherwise creating a powershell project will fail.
<!-- Describe your PR here. --> This adds a new SDK to the backend: PowerShell I've implemented these changes by copying what is done for platform elixir. I've tested the changes locally and everything seems to work fine AFAICT. frontend PR: #67576 <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Josh Ferge <josh.ferge@gmail.com>
the backend PR was merged so this is unblocked: |
Co-authored-by: ArthurKnaus <knauar@gmail.com>
<!-- Describe your PR here. --> This adds a new SDK to the backend: PowerShell I've implemented these changes by copying what is done for platform elixir. I've tested the changes locally and everything seems to work fine AFAICT. frontend PR: #67576 <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Josh Ferge <josh.ferge@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: ArthurKnaus <knauar@gmail.com>
linting is still failing:
|
that has nothing to do with the changes in the PR, it's broken on the main branch. It's just that the check runs because this PR changes the file (on other lines) |
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Is there anything that needs to be done for this to get merged? |
This adds a new SDK to the frontend: PowerShell
I've implemented these changes by copying what is done for platform elixir.
I've tested the changes locally and everything seems to work fine AFAICT.
backend PR: #67577
Resolves:
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.