Skip to content

🤖 Fix ValueError in NotificationActionsDetailsEndpoint #67843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

seer-by-sentry[bot]
Copy link
Contributor

👋 Hi there! This PR was automatically generated 🤖

Triggered by tillman.elser@sentry.io

Fixes SENTRY-33ST

The issue occurs because the 'action_id' parameter is expected to be an integer, but a string 'alert-backend-production' is being passed instead. This causes a ValueError when attempting to retrieve a NotificationAction object by its ID. To resolve this, we need to modify the convert_args method in the NotificationActionsDetailsEndpoint to handle cases where 'action_id' is not an integer and provide a meaningful error message.

The steps that were performed:

  1. Modify convert_args to handle non-integer action_id

📣 Instructions for the reviewer which is you, yes you:

  • If these changes were incorrect, please close this PR and comment explaining why.
  • If these changes were incomplete, please continue working on this PR then merge it.
  • If you are feeling confident in my changes, please merge this PR.

This will greatly help us improve the autofix system. Thank you! 🙏

If there are any questions, please reach out to the AI/ML Team on #proj-autofix

🤓 Stats for the nerds:

Prompt tokens: 45255
Completion tokens: 2411
Total tokens: 47666

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 28, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Apr 18, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Apr 18, 2024
@getsantry getsantry bot closed this Apr 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants