feat(trace): Change state priority on trace drawer resize #67885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the lag from resizing the trace drawer by removing render batching on the size updates and lowering the priority of state updates in a parent component. fixes getsentry/frontend-tsc#61
github-actions
bot
added
the
Scope: Frontend
scttcper
commented
Mar 28, 2024
Comment on lines
+72
to
+74
| flushSync(() => { | ||
| setSize(newSize); | ||
| }); |
There was a problem hiding this comment.
keeps the drawer close to the cursor, removes batching
scttcper
commented
Mar 28, 2024
| cancelAnimationTimeout(resizeAnimationTimeoutRef.current); | ||
| } | ||
| resizeAnimationTimeoutRef.current = requestAnimationTimeout(() => { | ||
| startTransition(() => { |
There was a problem hiding this comment.
marks this state update as low priority https://react.dev/reference/react/startTransition
There was a problem hiding this comment.
this function doesn't seem to exist on 17
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the lag from resizing the trace drawer by removing render batching on the size updates and lowering the priority of state updates in a parent component.
fixes https://github.com/getsentry/frontend-tsc/issues/61