Skip to content

fix(grouping): Callee and Caller Matchers have neither key nor pattern #67895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(grouping): Callee and Caller Matchers have neither key nor pattern #67895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/sentry/grouping/enhancer/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ def add_to_hint(self, hint, var):


class Enhancements:

# NOTE: You must add a version to ``VERSIONS`` any time attributes are added
# to this class, s.t. no enhancements lacking these attributes are loaded
# from cache.
Expand Down Expand Up @@ -181,7 +180,6 @@ def update_frame_components_contributions(self, components, frames, platform, ex
stacktrace_state = StacktraceState()
# Apply direct frame actions and update the stack state alongside
for rule in self._updater_rules:

for idx, action in rule.get_matching_frame_actions(
match_frames, platform, exception_data, in_memory_cache
):
Expand Down Expand Up @@ -354,7 +352,12 @@ def _as_updater_rule(self) -> Rule | None:
def as_dict(self):
matchers = {}
for matcher in self.matchers:
matchers[matcher.key] = matcher.pattern
if isinstance(matcher, CalleeMatch):
matchers["callee"] = f"{matcher.caller.description} {matcher.description}"
elif isinstance(matcher, CallerMatch):
matchers["caller"] = f"{matcher.description} {matcher.caller.description}"
else:
matchers[matcher.key] = matcher.pattern
return {"match": matchers, "actions": [str(x) for x in self.actions]}

def get_matching_frame_actions(
Expand Down