Skip to content

Filter in-app frames to decide for CODEOWNERS #67908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alxckn
Copy link
Contributor

@alxckn alxckn commented Mar 28, 2024

Fixes #57828 ?

I believe the assignment rules may in fact process the entire stack trace instead of simply the in-app frames.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (7d5ee4b) to head (fb4f2ae).
Report is 1368 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #67908      +/-   ##
==========================================
- Coverage   84.34%   84.31%   -0.03%     
==========================================
  Files        5314     5322       +8     
  Lines      237352   237819     +467     
  Branches    41050    41131      +81     
==========================================
+ Hits       200184   200512     +328     
- Misses      36950    37089     +139     
  Partials      218      218              
Files Coverage Δ
src/sentry/ownership/grammar.py 94.07% <100.00%> (-4.88%) ⬇️

... and 250 files with indirect coverage changes

@getsantry
Copy link
Contributor

getsantry bot commented Apr 19, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Apr 19, 2024
@getsantry getsantry bot closed this Apr 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore core modules' CODEOWNERS in traces
1 participant