Skip to content

🤖 Fix AttributeError in Metrics Query Execution #68163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

seer-by-sentry[bot]
Copy link
Contributor

@seer-by-sentry seer-by-sentry bot commented Apr 3, 2024

👋 Hi there! This PR was automatically generated 🤖

Triggered by riccardo.busetti@sentry.io

Fixes SENTRY-33A3

The issue arises from attempting to access a 'formula' attribute on a float object within the metrics query execution process. This is likely due to incorrect handling or parsing of query parameters, where a float value is mistakenly treated as an object that should contain a 'formula' attribute. The solution involves ensuring that query parameters are correctly parsed and handled, particularly when dealing with formulas and their parameters.

The steps that were performed:

  1. Ensure correct parsing of formula parameters
  2. Review formula handling in query preparation
  3. Add error handling for formula parameter parsing
  4. Test formula parameter handling with varied inputs

📣 Instructions for the reviewer which is you, yes you:

  • If these changes were incorrect, please close this PR and comment explaining why.
  • If these changes were incomplete, please continue working on this PR then merge it.
  • If you are feeling confident in my changes, please merge this PR.

This will greatly help us improve the autofix system. Thank you! 🙏

If there are any questions, please reach out to the AI/ML Team on #proj-autofix

🤓 Stats for the nerds:

Prompt tokens: 118577
Completion tokens: 4719
Total tokens: 123296

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 3, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Apr 25, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Apr 25, 2024
@getsantry getsantry bot closed this May 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants