devenv: remove legacy ensure-venv #68224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…venv-remove-ensure-venv
github-actions
bot
added
the
Scope: Backend
joshuarli
commented
Apr 3, 2024
Base automatically changed from
devenv-remove-legacy-sentry-cli-bash-reporting
to
master
April 4, 2024 18:56
asottile-sentry
approved these changes
Apr 4, 2024
| require() { | ||
| command -v "$1" >/dev/null 2>&1 | ||
| } | ||
|
|
||
| query-valid-python-version() { |
There was a problem hiding this comment.
this might still be useful -- I think there's still ways people can manually get out of sync ?
Bundle ReportChanges will increase total bundle size by 2 bytes ⬆️
|
joshuarli
commented
Apr 4, 2024
anonrig
approved these changes
Apr 10, 2024
joshuarli
commented
Apr 10, 2024
scripts/do.sh
Outdated
| @@ -16,20 +16,11 @@ https://github.com/getsentry/devenv#install | |||
| exit 1 | |||
| fi | |||
|
|
|||
| if [[ ${GETSENTRY:-0} -eq 1 ]]; then | |||
There was a problem hiding this comment.
soooo this is still needed, but not if i move make setup-git into devenv sync: https://github.com/getsentry/getsentry/pull/13540/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R28
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes a bunch of legacy code surrounding ensure-venv stuff by requiring devenv (it's already required in .envrc) and replacing it with a much simpler VIRTUAL_ENV check
also good with bootstrap here: getsentry/devenv#109