fix(hc): Change RPC schemas to be represented as OpenAPI #68345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove an extra layer of model name keys from the `inserted_map` attribute of a ControlImportChunk object inserted as setup. This has not previously caused a test breakage because the path being tested does not need to read the deserialized value, but it is inconsistent with the type annotations on `PrimaryKeyMap.mapping` and will break when we add validation when deserializing.
github-actions
bot
added
the
Scope: Backend
This was referenced Apr 5, 2024
markstory
reviewed
Apr 5, 2024
Because it's now a concrete method in IntegrationService.
Bundle ReportBundle size has no change ✅ |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
markstory
added a commit
that referenced
this pull request
May 14, 2024
Mulligan on #68345 that resolves the import issue that required a revert.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change RPC schemas that can't be represented in the OpenAPI format, generally because they rely on a fixed-length tuple with declared types at individual indexes. The success criterion is that the
sentry rpcschema --diagnosecommand (not present in this branch, but can be merged locally from #68337) indicates 0 errors.Because this branch covers breaking changes both to services and call sites, it will not be deployed to production as-is. We will use the five-step procedure for rolling out breaking RPC changes. However, to avoid having to redo steps, I'm hoping to get it reviewed all at once. (Most of the RPC changes are mechanistic, but there are a few design choices in the model changes -- names and such.)
Here are the RPC services being changed and associated errors from
sentry rpcschema --diagnosebeing fixed:I hope that's not too much to review at once. If it is, I could decompose it into separate PRs (but would then want to re-compose it for the sake of the five-step rollout process mentioned above, so yeah).