Skip to content

Fully enable reprocessing-v2 (frontend) and update logic showing "Reprocess Event" action #68412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2024

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Apr 8, 2024

This fully enables the feature by simply removing all the checks and early returns for the feature flag.

The logic to show the "Reprocess Event" action was updated so that all kinds of events that have debug files are eligible for reprocessing.

@Swatinem Swatinem self-assigned this Apr 8, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Bundle Report

Changes will increase total bundle size by 36.74kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 26.21MB 36.74kB ⬆️

@Swatinem Swatinem force-pushed the swatinem/reprocess-button-logic branch from 3efdb81 to a53ec28 Compare April 18, 2024 14:28
@Swatinem Swatinem requested a review from a team April 18, 2024 14:28
@Swatinem Swatinem requested a review from a team as a code owner April 18, 2024 14:28
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 18, 2024
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@Swatinem Swatinem changed the title Update logic showing the "Reprocess Event" action Fully enable reprocessing-v2 and update logic showing "Reprocess Event" action Apr 18, 2024
Copy link
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BE changes look good.
Could you please split up this PR for BE and FE changes?

@Swatinem Swatinem force-pushed the swatinem/reprocess-button-logic branch from 4ca5ee9 to 38ff36c Compare April 18, 2024 16:25
@Swatinem Swatinem changed the title Fully enable reprocessing-v2 and update logic showing "Reprocess Event" action Fully enable reprocessing-v2 (frontend) and update logic showing "Reprocess Event" action Apr 18, 2024
@Swatinem
Copy link
Member Author

Could you please split up this PR for BE and FE changes?

Done, BE changes split into #69204

@Swatinem Swatinem requested a review from armenzg April 18, 2024 16:25
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 79.72%. Comparing base (5f0e188) to head (4ca5ee9).
Report is 19 commits behind head on master.

❗ Current head 4ca5ee9 differs from pull request most recent head 38ff36c. Consider uploading reports for the commit 38ff36c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #68412      +/-   ##
==========================================
+ Coverage   79.70%   79.72%   +0.02%     
==========================================
  Files        6421     6426       +5     
  Lines      285345   285579     +234     
  Branches    49166    49212      +46     
==========================================
+ Hits       227437   227681     +244     
+ Misses      57471    57461      -10     
  Partials      437      437              
Files Coverage Δ
src/sentry/api/endpoints/event_reprocessable.py 90.47% <ø> (+2.97%) ⬆️
src/sentry/api/endpoints/group_reprocessing.py 47.61% <ø> (+1.78%) ⬆️
...s/interfaces/debugMeta/debugImageDetails/index.tsx 73.13% <ø> (ø)
static/app/views/issueDetails/actions/index.tsx 67.36% <ø> (ø)
...sueDetails/groupEventDetails/groupEventDetails.tsx 86.36% <ø> (-0.31%) ⬇️
static/app/views/issueDetails/header.tsx 78.72% <ø> (+2.72%) ⬆️
static/app/views/issueList/overview.tsx 75.85% <100.00%> (-0.11%) ⬇️
static/app/views/issueList/utils.tsx 92.30% <ø> (ø)
static/app/utils/displayReprocessEventAction.tsx 86.66% <85.71%> (+1.30%) ⬆️
static/app/views/issueDetails/groupDetails.tsx 75.10% <14.28%> (+0.98%) ⬆️

... and 29 files with indirect coverage changes

@armenzg
Copy link
Member

armenzg commented Apr 19, 2024

Could you please split up this PR for BE and FE changes?

Done, BE changes split into #69204

Could you please remove the BE changes from this PR? You won't be able to merge this PR as long as both FE and BE changes are in the same PR.

Copy link
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the screenshot before and after to the description of the PR? It will help future people to look back at what changed.

@getsantry
Copy link
Contributor

getsantry bot commented May 11, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label May 11, 2024
@loewenheim loewenheim removed the Stale label May 13, 2024
loewenheim pushed a commit that referenced this pull request May 13, 2024
This fully enables the feature by simply removing all the checks and
early returns for the feature flag.

---

Split out from #68412
…eprocess Event" action

This fully enables the feature by simply removing all the checks and early returns for the feature flag.

The logic was updated so that all kinds of events that have debug files are eligible for reprocessing.
@Swatinem
Copy link
Member Author

Could you please add the screenshot before and after to the description of the PR?

There is no visual changes with this PR. It would just display this action more frequently: https://docs.sentry.io/product/issues/reprocessing/

@Swatinem Swatinem merged commit 4bdb82e into master May 22, 2024
43 checks passed
@Swatinem Swatinem deleted the swatinem/reprocess-button-logic branch May 22, 2024 07:12
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants