-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Fully enable reprocessing-v2
(frontend) and update logic showing "Reprocess Event" action
#68412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bundle ReportChanges will increase total bundle size by 36.74kB ⬆️
|
3efdb81
to
a53ec28
Compare
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
reprocessing-v2
and update logic showing "Reprocess Event" action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The BE changes look good.
Could you please split up this PR for BE and FE changes?
4ca5ee9
to
38ff36c
Compare
reprocessing-v2
and update logic showing "Reprocess Event" actionreprocessing-v2
(frontend) and update logic showing "Reprocess Event" action
Done, BE changes split into #69204 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #68412 +/- ##
==========================================
+ Coverage 79.70% 79.72% +0.02%
==========================================
Files 6421 6426 +5
Lines 285345 285579 +234
Branches 49166 49212 +46
==========================================
+ Hits 227437 227681 +244
+ Misses 57471 57461 -10
Partials 437 437
|
Could you please remove the BE changes from this PR? You won't be able to merge this PR as long as both FE and BE changes are in the same PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add the screenshot before and after to the description of the PR? It will help future people to look back at what changed.
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This fully enables the feature by simply removing all the checks and early returns for the feature flag. --- Split out from #68412
…eprocess Event" action This fully enables the feature by simply removing all the checks and early returns for the feature flag. The logic was updated so that all kinds of events that have debug files are eligible for reprocessing.
38ff36c
to
1e59ccf
Compare
There is no visual changes with this PR. It would just display this action more frequently: https://docs.sentry.io/product/issues/reprocessing/ |
This fully enables the feature by simply removing all the checks and early returns for the feature flag.
The logic to show the "Reprocess Event" action was updated so that all kinds of events that have debug files are eligible for reprocessing.