feat(issue-alerts): Group unique conditions #68517
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
schew2381
changed the base branch from
master
to
seiji/feat/create-initial-processing-method
schew2381
force-pushed
the
seiji/feat/create-initial-processing-method
branch
from
f505439 to
6dd8aeb
Compare
Base automatically changed from
seiji/feat/create-initial-processing-method
to
master
April 11, 2024 21:36
Bundle ReportBundle size has no change ✅ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #68517 +/- ##
==========================================
- Coverage 79.72% 79.64% -0.09%
==========================================
Files 6423 6423
Lines 284723 284793 +70
Branches 49046 49061 +15
==========================================
- Hits 226998 226818 -180
- Misses 57327 57577 +250
Partials 398 398
|
ceorourke
reviewed
Apr 16, 2024
| @@ -289,7 +289,7 @@ def push_to_hash( | |||
|
|
|||
| def get_hash( | |||
| self, model: type[models.Model], field: dict[str, models.Model | str | int] | |||
| ) -> dict[str, str]: | |||
| ) -> dict[str, int]: | |||
There was a problem hiding this comment.
[{'2:3': '4'}] - this is how Redis returns it to us. I could turn the value into an int before returning if that helps? For now I'm gonna leave this as it is though.
ceorourke
added a commit
that referenced
this pull request
Apr 17, 2024
Pulls out the non-functional changes from #68517 which are mostly typing related.
schew2381
added a commit
that referenced
this pull request
May 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done by @ceorourke in #69068 and #69167