feat(sdk-crash): Keep more exception fields #68680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep non PII related fields: synthetic and errno with number and name.
philipphofmann
added
the
Scope: Backend
Bundle ReportBundle size has no change ✅ |
jjbayer
approved these changes
Apr 11, 2024
c298lee
pushed a commit
that referenced
this pull request
Apr 12, 2024
Keep non PII related fields: synthetic and errno with number and name.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep non PII related fields: synthetic and errno with number and name.
We need to keep the synthetic field for grouping because otherwise we group by exception type, which contains memory addresses, see:
I also added errno with number and name because they don't contain PII, and can be useful.