fix(profiling): keep frame-level platform information when available in mixed stack traces #68694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
so we should only set it explicitly when we're dealing with symbolicated frames
Bundle ReportChanges will increase total bundle size by 2.87kB ⬆️
|
phacops
approved these changes
Apr 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #68694 +/- ##
===========================================
+ Coverage 68.78% 79.73% +10.95%
===========================================
Files 6414 6415 +1
Lines 283991 284078 +87
Branches 48934 48936 +2
===========================================
+ Hits 195339 226506 +31167
+ Misses 88259 57185 -31074
+ Partials 393 387 -6
|
since at this point we're dealing with platforms that didn't set it in previous steps
phacops
approved these changes
Apr 11, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
|
PR reverted: 6accd3f |
c298lee
pushed a commit
that referenced
this pull request
Apr 12, 2024
…in mixed stack traces (#68694) Way back we added [frame-level](https://github.com/getsentry/vroom/blob/main/internal/frame/frame.go#L42) platform information in `vroom`, but we're not passing this information down from `sentry`. This will help us to distinguish between `js` and `cocoa` frames in mixed stack traces scenarios (such as for react-native).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Way back we added frame-level platform information in
vroom, but we're not passing this information down fromsentry.This will help us to distinguish between
jsandcocoaframes in mixed stack traces scenarios (such as for react-native).