fix(sessions): Fix metrics querybuilder

[lynnagara]

not sure why this had sessions as the dataset, sessions doesn't exist anymore

[codecov]

Bundle Report

Changes will decrease total bundle size by 552 bytes ⬇️

Bundle name	Size	Change
sentry-webpack-bundle-array-push	26.3MB	552 bytes ⬇️

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.98%. Comparing base (0c8f916) to head (8e5b200).
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #68745      +/-   ##
==========================================
+ Coverage   75.75%   79.98%   +4.22%     
==========================================
  Files        6490     6492       +2     
  Lines      289797   289959     +162     
  Branches    49928    49957      +29     
==========================================
+ Hits       219538   231923   +12385     
+ Misses      69845    57625   -12220     
+ Partials      414      411       -3     

Files	Coverage Δ
src/sentry/snuba/metrics/query_builder.py	88.70% <ø> (-3.39%)	⬇️

... and 805 files with indirect coverage changes

[iambriccardo]

Good catch, this is not impacting the product though since the dataset won't be used because this code is not querying anything. The high coupling of query builders with parsing logic makes it quite hard to use exclusively the parsing logic.

[getsantry]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[lynnagara]

@iambriccardo Do you have advice on how to resolve the AttributeError: 'ReleaseHealthQueryBuilder' object has no attribute 'use_on_demand' issue in the failing tests... Is it supposed to be defined on on that class?

[iambriccardo]

@iambriccardo Do you have advice on how to resolve the AttributeError: 'ReleaseHealthQueryBuilder' object has no attribute 'use_on_demand' issue in the failing tests... Is it supposed to be defined on on that class?

I will check this out.

[iambriccardo]

I have tried several solutions to fix this problem but due to how intertwined the parsing logic is with the Sessions dataset configuration, our best bet is to temporarily keep this like it they are right now and in the future we will switch to the new metrics/query endpoint which has a completely new way of parsing queries.