ref(ui): Simplify badges implementation #68946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will decrease total bundle size by 2.36kB ⬇️
|
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-ui-simplify-badges-implementation
branch
from
331d7fc to
9f3c748
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-ui-simplify-badges-implementation
branch
from
0be814f to
bbefb4e
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-ui-simplify-badges-implementation
branch
from
9f205bf to
1f6e43f
Compare
ryan953
reviewed
Apr 16, 2024
Comment on lines
+32
to
+37
| const membersUrl = | ||
| member && org && !disableLink | ||
| ? `/settings/${org.slug}/members/${member.id}/` | ||
| : undefined; | ||
|
|
||
| const StyledNameAndEmail = styled('div')` | ||
| flex-shrink: 1; | ||
| min-width: 0; | ||
| line-height: 1; | ||
| `; | ||
|
|
||
| const StyledEmail = styled('div')` | ||
| font-size: 0.875em; | ||
| margin-top: ${space(0.25)}; | ||
| color: ${p => p.theme.gray300}; | ||
| ${p => p.theme.overflowEllipsis}; | ||
| `; | ||
|
|
||
| interface NameProps { | ||
| hideEmail: boolean; | ||
| to: LinkProps['to']; | ||
| useLink: boolean; | ||
| children?: React.ReactNode; | ||
| return <UserBadge to={membersUrl} user={user} {...props} />; |
ryan953
reviewed
Apr 16, 2024
| const Wrapper = styled('div')` | ||
| display: flex; | ||
| gap: ${space(1)}; |
There was a problem hiding this comment.
Idk if this is properly replacing the margin-right that StyledAvatar had before.
The problem I'm seeing is that the replay breadcrumbItem has no spacing now:
There was a problem hiding this comment.
There was a problem hiding this comment.
waiting to see the combo with #69009, will return to look again!
There was a problem hiding this comment.
this will have a merge conflict once #69009 merges
- The UserBadge no longer has a bunch of custom styling and uses the existing styles - The MemberBadge delegates to the User badge now
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-ui-simplify-badges-implementation
branch
from
71de491 to
cc8df41
Compare
ryan953
approved these changes
Apr 16, 2024
evanpurkhiser
deleted the
evanpurkhiser/ref-ui-simplify-badges-implementation
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UserBadge no longer has a bunch of custom styling and uses the
existing styles
The MemberBadge delegates to the User badge now