feat(replays): switch to replay_id column from tag #68950
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #68950 +/- ##
===========================================
+ Coverage 58.23% 79.71% +21.47%
===========================================
Files 6415 6425 +10
Lines 284354 284956 +602
Branches 49001 49072 +71
===========================================
+ Hits 165583 227142 +61559
+ Misses 118367 57415 -60952
+ Partials 404 399 -5
|
JoshFerge
force-pushed
the
jferg/discov-replay
branch
from
37d6b16 to
824d4a8
Compare
| # replayId. We allow this query for backwards compatibility, | ||
| # but in the future shouldn't be displayed in the UI anywhere | ||
| # as a suggested column. | ||
| REPLAY_ID_DEPRECATED = Column( |
There was a problem hiding this comment.
Because this was exposed to discover/dashboards, you'll want to make sure it's not being used by customers if you were to remove it.
| if data_source == Dataset.Discover: | ||
| search_query_func = discover.query | ||
| elif data_source == Dataset.IssuePlatform: | ||
| search_query_func = issue_platform.query # type: ignore[assignment] |
There was a problem hiding this comment.
Just checking we actually write to this col from issue platform?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok - so as long as it's in the context for the event we pass to snuba it should work...
Are replays associated to transactions? If so, then perf issues from transactions should work automatically. Other issue platform types that make a "synthetic" event would need to explicitly include it there
There was a problem hiding this comment.
yup, replays are associated to transactions. its done via the dynamic sampling context, which then adds the replay context in relay. and for others:
rage click issue:
feedback issue:
Crons
-- not applicable
that should be everything
we've been writing this column for a little over a year now, just haven't been querying on it since we had the tag as well. |
I see, I missed that the snuba pr is just adding the col to the merge table 👍 |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
We want to have the replay_id column be queried on instead of the tag that we previously had, as we no longer are populating the tag for non javascript platforms. Depends on getsentry/snuba#5777.
We want to have the replay_id column be queried on instead of the tag that we previously had, as we no longer are populating the tag for non javascript platforms. Depends on getsentry/snuba#5777.