feat(dashboards): Allow removing of wrapper in lazyrender #68998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit be24d67.
Once the dashboard widget is on the screen, remove the lazy placeholder and just render the children.
github-actions
bot
added
the
Scope: Frontend
JonasBa
approved these changes
Apr 16, 2024
Bundle ReportChanges will decrease total bundle size by 15.42kB ⬇️
|
obostjancic
approved these changes
Apr 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit be24d67
Updating react-lazyload added an additional div wrapper to use as the visible ref. Dashboard styles rely on lots of overflow and full height styles and a wrapping div breaks them since you want the overflow scrollbars to be on that element.
This adds the ability for our lazy render to remove the wrapper once the component is on the screen.
good test dashboard