Skip to content

ref(ui): Improve member loading in actor avatar #69002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

evanpurkhiser
Copy link
Member

Right now if the member isn't present in the store when the avatar
renders we'll never end up showing the users avatar

@evanpurkhiser evanpurkhiser requested a review from scttcper April 16, 2024 17:05
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 16, 2024
Copy link
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get rid of the it.only

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-ui-improve-member-loading-in-actor-avatar branch from 6bb55b1 to 21fe8cd Compare April 16, 2024 17:45
Copy link

codecov bot commented Apr 16, 2024

Bundle Report

Changes will decrease total bundle size by 14.66kB ⬇️

Bundle name Size Change
app-webpack-bundle-array-push 26.28MB 26.28MB ⬆️
sentry-webpack-bundle-array-push (removed) 26.29MB ⬇️

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-ui-improve-member-loading-in-actor-avatar branch from 21fe8cd to 3c99041 Compare April 16, 2024 17:55
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) April 16, 2024 17:58
Right now if the member isn't present in the store when the avatar
renders we'll never end up showing the users avatar
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-ui-improve-member-loading-in-actor-avatar branch from 3c99041 to fe29dc8 Compare April 16, 2024 18:54
@evanpurkhiser evanpurkhiser merged commit 92e8a0c into master Apr 16, 2024
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-ui-improve-member-loading-in-actor-avatar branch April 16, 2024 19:05
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants