Skip to content

chore(roles): remove team.org_role once and for all #69003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cathteng
Copy link
Member

Resolves #66247

@cathteng cathteng requested review from azaslavsky and a team April 16, 2024 17:13
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 16, 2024
@azaslavsky
Copy link
Contributor

I may have jumped the gun on this one. Looking into it now - sorry for the churn!

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.66%. Comparing base (9495198) to head (d664c99).

❗ Current head d664c99 differs from pull request most recent head 1be67f2. Consider uploading reports for the commit 1be67f2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #69003       +/-   ##
===========================================
+ Coverage   42.42%   79.66%   +37.23%     
===========================================
  Files        5485     6427      +942     
  Lines      231885   284961    +53076     
  Branches    39879    49078     +9199     
===========================================
+ Hits        98379   227013   +128634     
+ Misses     132539    57582    -74957     
+ Partials      967      366      -601     
Files Coverage Δ
src/sentry/backup/imports.py 93.50% <100.00%> (-3.32%) ⬇️

... and 4322 files with indirect coverage changes

@azaslavsky
Copy link
Contributor

Seems like I made a mistake here - we'll actually have to wait until 24.5.0, since this field was still being included in in 24.3.0 :(

See:

I have confirmed it is gone in 24.4.0 though, so the next release should let us (finally) put it to bed.

@getsantry
Copy link
Contributor

getsantry bot commented May 8, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label May 8, 2024
@cathteng cathteng force-pushed the cathy/team-org-role/remove-shim branch from d664c99 to 1be67f2 Compare May 14, 2024 23:53
@cathteng cathteng closed this May 16, 2024
azaslavsky added a commit that referenced this pull request May 17, 2024
This completes the too-early attempt from this PR:
#69003

Closes #66247

---------

Co-authored-by: Cathy Teng <cathy.teng@sentry.io>
cmanallen pushed a commit that referenced this pull request May 21, 2024
This completes the too-early attempt from this PR:
#69003

Closes #66247

---------

Co-authored-by: Cathy Teng <cathy.teng@sentry.io>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2024
@cathteng cathteng deleted the cathy/team-org-role/remove-shim branch December 23, 2024 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sentry.team.org_role after self-hosted 23.4.0 is released
2 participants