-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
chore(roles): remove team.org_role once and for all #69003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I may have jumped the gun on this one. Looking into it now - sorry for the churn! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #69003 +/- ##
===========================================
+ Coverage 42.42% 79.66% +37.23%
===========================================
Files 5485 6427 +942
Lines 231885 284961 +53076
Branches 39879 49078 +9199
===========================================
+ Hits 98379 227013 +128634
+ Misses 132539 57582 -74957
+ Partials 967 366 -601
|
Seems like I made a mistake here - we'll actually have to wait until 24.5.0, since this field was still being included in in 24.3.0 :( See:
I have confirmed it is gone in 24.4.0 though, so the next release should let us (finally) put it to bed. |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
d664c99
to
1be67f2
Compare
Resolves #66247