chore(actor): Move ActorTuple to its own file so that it's not tied to models during import #69005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to models during import We want to use `ActorTuple` in the issue platform, but it causes a lot of import loops currently. Moving this to a separate place so it can more easily be imported
github-actions
bot
added
the
Scope: Backend
wedamija
commented
Apr 16, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| user = user_service.get_by_username(username=actor_identifier)[0] | ||
| return cls(user.id, User) | ||
| except IndexError as e: | ||
| raise serializers.ValidationError(f"Unable to resolve actor identifier: {e}") |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
vartec
approved these changes
Apr 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use
ActorTuplein the issue platform, but it causes a lot of import loops currently. Moving this to a separate place so it can more easily be imported