Skip to content

fix(replay): Filter empty querystring params from replay list api call #69007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Apr 16, 2024

Following up on #68849

This filters empty query params, which don't need to be sent to the server. Also in #68849 i missed a few important fields in the list.

@ryan953 ryan953 requested a review from a team as a code owner April 16, 2024 17:49
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 16, 2024
@ryan953 ryan953 enabled auto-merge (squash) April 16, 2024 18:01
@ryan953 ryan953 merged commit 60f41ee into master Apr 16, 2024
@ryan953 ryan953 deleted the ryan953/replay-list-filter-empty-qs branch April 16, 2024 18:10
armenzg pushed a commit that referenced this pull request Apr 17, 2024
#69007)

Following up on #68849

This filters empty query params, which don't need to be sent to the
server. Also in #68849 i missed a few important fields in the list.
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants