Skip to content

ref(replays): hide console tab for mobile replays #69012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Apr 16, 2024

hiding because we decided the console tab isn't useful for video replays; most useful logging context will come from breadcrumbs instead

SCR-20240416-kdcu

@michellewzhang michellewzhang requested a review from a team as a code owner April 16, 2024 18:08
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 16, 2024
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add in comments + PR description why we're hiding?

Copy link

codecov bot commented Apr 16, 2024

Bundle Report

Changes will decrease total bundle size by 13.89kB ⬇️

Bundle name Size Change
app-webpack-bundle-array-push 26.29MB 26.29MB ⬆️
sentry-webpack-bundle-array-push (removed) 26.31MB ⬇️

@michellewzhang michellewzhang merged commit 915692b into master Apr 16, 2024
42 checks passed
@michellewzhang michellewzhang deleted the mz/hide-console branch April 16, 2024 18:24
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants