From d2ed28341b3f300899930504ec6daf598f7f1361 Mon Sep 17 00:00:00 2001 From: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com> Date: Tue, 16 Apr 2024 11:07:38 -0700 Subject: [PATCH 1/2] ref(replays): hide console tab for mobile replays --- static/app/views/replays/detail/layout/focusTabs.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/static/app/views/replays/detail/layout/focusTabs.tsx b/static/app/views/replays/detail/layout/focusTabs.tsx index 8f8ac19757562d..c0d77486d3f272 100644 --- a/static/app/views/replays/detail/layout/focusTabs.tsx +++ b/static/app/views/replays/detail/layout/focusTabs.tsx @@ -27,7 +27,7 @@ function getReplayTabs({ return { [TabKey.BREADCRUMBS]: t('Breadcrumbs'), - [TabKey.CONSOLE]: t('Console'), + [TabKey.CONSOLE]: isVideoReplay ? null : t('Console'), [TabKey.NETWORK]: t('Network'), [TabKey.ERRORS]: t('Errors'), [TabKey.TRACE]: hasTraceTable || isVideoReplay ? null : t('Trace'), From 2b6541aa1414d331c96682154ad6d42c991bbf92 Mon Sep 17 00:00:00 2001 From: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com> Date: Tue, 16 Apr 2024 11:12:10 -0700 Subject: [PATCH 2/2] comments --- static/app/views/replays/detail/layout/focusTabs.tsx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/static/app/views/replays/detail/layout/focusTabs.tsx b/static/app/views/replays/detail/layout/focusTabs.tsx index c0d77486d3f272..096497843a57cd 100644 --- a/static/app/views/replays/detail/layout/focusTabs.tsx +++ b/static/app/views/replays/detail/layout/focusTabs.tsx @@ -25,6 +25,11 @@ function getReplayTabs({ // The new trace table inside Breadcrumb items: const hasTraceTable = organization.features.includes('session-replay-trace-table'); + // For video replays, we hide the console, a11y, trace, and memory tabs + // The console tab isn't useful for video replays; most of the useful logging + // context will come from breadcrumbs + // A11y, trace, and memory aren't applicable for mobile + return { [TabKey.BREADCRUMBS]: t('Breadcrumbs'), [TabKey.CONSOLE]: isVideoReplay ? null : t('Console'),